Anchor :visited styles (HPE Theme) about grommet-docs HOT 6 CLOSED

An anchor with an empty href (href=""), will apply :visited styles.

from grommet-docs.

This appears to be an issue with the color defaults within the HPE Grommet theme. All themes but HPE set the $link-color variable to a color value while the HPE theme sets the $link-color value to inherit. This setting will inherit the HTML base color value of #333.

Updating the $brand-link-color value in the HPE theme to $brand-color will resolve this issue however this will change the default Anchor styling of all HPE themed grommet applications.

from grommet-docs.

@karatechops the intended behavior is to change the font color in the HPE theme to $brand-color. The only concern is if this would change the standard anchors (non-primary) as those are only 16px font. The HPE green does not meet WCAG 2.0 AA rating on a white background unless the font is at least 19px. I wonder if that's the reason this was done differently in the first place.

from grommet-docs.

@bryanjacquot changing the link color to $brand-color would adjust all the links. A potential workaround is to use SCSS to target the primary Anchors and set their color to $brand-color, the primary Anchors default to 19px while base Anchor styling is 16px. With this solution the non primary Anchor tags would remain #333. I can submit a PR if this sounds like a fix.

from grommet-docs.

@karatechops yep, that sounds like the right direction. Thanks!

from grommet-docs.

Proposed fix in grommet PR #879

from grommet-docs.