Giter VIP home page Giter VIP logo

Comments (2)

courtneyb avatar courtneyb commented on August 26, 2024

I like this idea. Would we want to make the type of locking configurable by backbeat clients? I think we should make sure to include client_id as a unique arg so multiple clients couldn't step on each other with workflows like: { name: "update", subject: {record_uuid: some_uuid } }.

Since we're turning backbeat server into a gem, do you think there are clients that would prefer to add and configure 'sidekiq-unique-jobs' independently of backbeat? Or would we always include it and pass all the configuration through backbeat's configs?

from backbeat.

carlthuringer avatar carlthuringer commented on August 26, 2024

The more I think about this, the more I think it's a step too far. If we have a performance issue around thousands of blocking jobs under one workflow, then we should address that performance issue rather than constructing arbitrary rules around who gets to use how much of the queue, dynamic partitioning, or other strategies for sharing a limited resource.

I'm considering waiting before implementing some heavy-handed resource protection. Sidekiq is really fast. Perhaps all we need is to enforce a timeout on client callbacks and address the performance issue with having thousands of blocking jobs on one workflow.

from backbeat.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.