Comments (6)
@feliksik In order to use the grpc_retry
CallOption
s within your code invocations, you need to use either the UnaryClient or ServerClient interceptors when you instantiate the connection (on grpc.Dial
)
These interceptors are the things that actually drive the calling logic, and the CallOptions
are just per-call overrides.
You spotted a bug that I have no immediate way of fixing. You see, the CallOptions
interface in grpc
itself has private methods. Which means one needs to resort to a hack:
- the
grpc_retry.CallOption
anonymously implements thegrpc.CallOption
interface. However it doesn't implement the privatebefore
andafter
functions, because it can't. - the interceptors strip out these
grpc_retry.CallOptions
before passing them to thegrpc.invoker
call which relies onbefore
andafter
being implemented.
As such, the code panics. Sadly there are two ways around this:
- either make the
grpc_retry.CallOption
use one of theHeaders
,Failfast
,Peer
orTrailers
grpc.CallOptions
as parents, and thus potentially disable the ability to use one of them by the user - or work with upstream to implent
grpc.CallOptions.Noop
. I'll file a bug.
from go-grpc-middleware.
Let's see what upstream responds, this is a snippet of a test that will make it fail:
func (s *RetrySuite) TestCallOptionsDontPanicWithoutMiddleware() {
s.srv.resetFailingConfiguration(3, codes.DataLoss, noSleep) // see retriable_errors
nonMiddlewareClient := s.NewClient()
_, err := nonMiddlewareClient.Ping(s.SimpleCtx(), goodPing,
grpc_retry.WithMax(5),
//grpc_retry.WithBackoff(grpc_retry.BackoffLinear(1*time.Millisecond)),
//grpc_retry.WithCodes(codes.Aborted, codes.InvalidArgument),
//grpc_retry.WithPerRetryTimeout(30*time.Millisecond),
)
require.NoError(s.T(), err, "the third invocation should succeed")
}
from go-grpc-middleware.
Thanks for the clear response! I'll just make sure to use an interceptor in Dial() then.
When the NoopOption would be implemented upstream, I'm still not sure how the internals work to apply the grpc_retry.WithMax(5) magically to the correct interceptor... but I can work around that.
from go-grpc-middleware.
When the NoopOption is implemented, you will still need to have an interceptor implemented. A simple option is not going to be enough.
from go-grpc-middleware.
So it seems upstream has a PR for it:
grpc/grpc-go#1244
So there's hope for a proper fix! :)
from go-grpc-middleware.
Yup, there's a fix for it upstream, and we'll wait for the 1.4 gRPC Go release.
from go-grpc-middleware.
Related Issues (20)
- Adding `grpc_code` label to prometheus `grpc_server_handling_seconds` metric HOT 5
- With HOT 1
- Logging interceptor does not correctly log client calls sent from a server HOT 4
- Support for connect go HOT 5
- "make test" and "make lint" ignore failures
- Support for WithSubsystem() HOT 5
- [retry-middleware] Stream is finished when retry timeout ends HOT 2
- Support loggging grpc status details HOT 1
- Add source and target endpoint as label for all client/server grpc metrics HOT 2
- Support ignore logging for v2(already attached PR) HOT 3
- Prometheus metrics label value inconsistency between Go and Java HOT 3
- [logging] disable option does not work with request/response fields HOT 6
- go-grpc-middleware/providers/openmetrics/v2 v2.0.0-rc.3 dependency of go-grpc-middleware/v2 v2.0.1 broken HOT 8
- Q: Logger migration HOT 2
- Support extensibility of retry condition
- [feat]: logging should loging grpc request msg HOT 1
- Example will log only first field HOT 3
- Add Capability to Override Base Timeout for Specific API HOT 1
- Use retry hooks for adding retry metrics
- logging.InjectFields does not work. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-grpc-middleware.