Comments (6)
afifurrohman-id
commented on June 5, 2024
1
Can you try returning the errors from server (refer RouteChat example) and log at client side. Also, share both server and client logs
I have try reproduced and modify those example with if err panic and it's seem still work.
But instead, like in my issue description it panic when i try start from scratch.
Here my client log:
GRPC_GO_LOG_VERBOSITY_LEVEL=99 GRPC_GO_LOG_SEVERITY_LEVEL=info go run cmd/client/main.go
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel created
2024/05/05 10:51:27 INFO: [core] [Channel #1]original dial target is: "localhost:50051"
2024/05/05 10:51:27 INFO: [core] [Channel #1]parsed dial target is: resolver.Target{URL:url.URL{Scheme:"localhost", Opaque:"50051", User:(*url.Userinfo)(nil), Host:"", Path:"", RawPath:"", OmitHost:false, ForceQuery:false, RawQuery:"", Fragment:"", RawFragment:""}}
2024/05/05 10:51:27 INFO: [core] [Channel #1]fallback to scheme "dns"
2024/05/05 10:51:27 INFO: [core] [Channel #1]parsed dial target is: dns:///localhost:50051
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel authority set to "localhost:50051"
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel exiting idle mode
2024/05/05 10:51:27 INFO: [core] [Channel #1]Resolver state updated: {
"Addresses": [
{
"Addr": "127.0.0.1:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
},
{
"Addr": "[::1]:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Endpoints": [
{
"Addresses": [
{
"Addr": "127.0.0.1:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Attributes": null
},
{
"Addresses": [
{
"Addr": "[::1]:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Attributes": null
}
],
"ServiceConfig": null,
"Attributes": null
} (resolver returned new addresses)
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel switches to new LB policy "pick_first"
2024/05/05 10:51:27 INFO: [core] [pick-first-lb 0xc000094cf0] Received new config {
"shuffleAddressList": false
}, resolver state {
"Addresses": [
{
"Addr": "127.0.0.1:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
},
{
"Addr": "[::1]:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Endpoints": [
{
"Addresses": [
{
"Addr": "127.0.0.1:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Attributes": null
},
{
"Addresses": [
{
"Addr": "[::1]:50051",
"ServerName": "",
"Attributes": null,
"BalancerAttributes": null,
"Metadata": null
}
],
"Attributes": null
}
],
"ServiceConfig": null,
"Attributes": null
}
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel created
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel Connectivity change to CONNECTING
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel Connectivity change to CONNECTING
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel picks a new address "127.0.0.1:50051" to connect
2024/05/05 10:51:27 INFO: [core] [pick-first-lb 0xc000094cf0] Received SubConn state update: 0xc000094d80, {ConnectivityState:CONNECTING ConnectionError:<nil>}
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel Connectivity change to READY
2024/05/05 10:51:27 INFO: [core] [pick-first-lb 0xc000094cf0] Received SubConn state update: 0xc000094d80, {ConnectivityState:READY ConnectionError:<nil>}
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel Connectivity change to READY
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
stream create recv:
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel Connectivity change to SHUTDOWN
2024/05/05 10:51:27 INFO: [core] [Channel #1]Closing the name resolver
2024/05/05 10:51:27 INFO: [core] [Channel #1]ccBalancerWrapper: closing
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel Connectivity change to SHUTDOWN
2024/05/05 10:51:27 INFO: [core] [Channel #1 SubChannel #2]Subchannel deleted
2024/05/05 10:51:27 INFO: [transport] [client-transport 0xc0000e6488] Closing: rpc error: code = Canceled desc = grpc: the client connection is closing
2024/05/05 10:51:27 INFO: [core] [Channel #1]Channel deleted
Here my server log:
GRPC_GO_LOG_VERBOSITY_LEVEL=99 GRPC_GO_LOG_SEVERITY_LEVEL=info go run cmd/server/main.go
2024/05/05 10:51:27 INFO: [core] [Server #1]Server created
2024/05/05 10:51:27 INFO: [core] [Server #1 ListenSocket #2]ListenSocket created
2024/05/05 10:51:27 INFO: [transport] [server-transport 0xc000002180] Closing: EOF
panic: rpc error: code = Canceled desc = context canceled
goroutine 50 [running]:
main.(*Server).Stream(0xc45e80?, {0x961258, 0xc0000255d0})
/home/user/grpc/cmd/server/main.go:22 +0xb8
example.com/grpc/model._Empty_Stream_Handler({0x831420?, 0xcbdb40}, {0x95f138, 0xc0000b6b40})
/home/user/grpc/model/service_grpc.pb.go:101 +0xd8
google.golang.org/grpc.(*Server).processStreamingRPC(0xc0001ac200, {0x95e438, 0xc000280000}, {0x9617d8, 0xc000002180}, 0xc0000d3e60, 0xc0001b8ea0, 0xc49d60, 0x0)
/home/user/go/pkg/mod/google.golang.org/[email protected]/server.go:1663 +0x1208
google.golang.org/grpc.(*Server).handleStream(0xc0001ac200, {0x9617d8, 0xc000002180}, 0xc0000d3e60)
/home/user/go/pkg/mod/google.golang.org/[email protected]/server.go:1784 +0xe3a
google.golang.org/grpc.(*Server).serveStreams.func2.1()
/home/user/go/pkg/mod/google.golang.org/[email protected]/server.go:1019 +0x8b
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 22
/home/user/go/pkg/mod/google.golang.org/[email protected]/server.go:1030 +0x125
exit status 2
from grpc-go.
purnesh42H
commented on June 5, 2024
1
Thanks for sharing the logs @afifurrohman-id. Based on the client and server logs, the setup is working as intended.
Establishing Connection:
The logs indicate that the gRPC client successfully establishes a connection (Channel 1) with the server (127.0.0.1:50051). The channel transitions through the CONNECTING and READY states, which suggests that the client is able to communicate with the server.
Stream Communication:
The client initiates a streaming RPC (Stream) to the server and continuously receives responses (stream create recv:) from the server. This behavior aligns with the intended use of bidirectional streaming where the client sends messages and receives responses asynchronously.
Channel Cleanup on Completion:
The logs show the channel transitioning to the SHUTDOWN state after the client completes its communication with the server. This is expected behavior for gracefully closing the gRPC channel and associated resources once the client-side operations are finished (for range max finishes).
Client Connection Closure:
The closure of the client connection (client-transport) with a Canceled error message indicates that the client is closing the connection intentionally or in response to some application-specific condition (e.g., all expected messages received, end of communication).
These are some improvements you can do to ensure controlled concurrency, timeout handling, and reliable error management in your gRPC client
- Use context.WithTimeout to create a context with a timeout for gRPC operations. This ensures that operations respect a maximum duration and handle timeouts gracefully.
- Implement controlled concurrency using a worker pool or synchronization mechanisms (e.g., wait groups) to limit the number of concurrent goroutines executing DoStream. This prevents excessive goroutine creation and manages resource usage effectively.
var wg sync.WaitGroup
for i := 0; i < max; i++ {
wg.Add(1)
go func() {
defer wg.Done()
DoStream(&Config{ctx, client, wait})
}()
}
wg.Wait() // Wait for all goroutines to complete
- Replace panic(err) with explicit error handling using log or returning errors to the caller for proper error propagation and graceful termination of operations.
from grpc-go.
purnesh42H
commented on June 5, 2024
1
Closing the issue for now. Feel free to reopen if any more clarification is needed
from grpc-go.
afifurrohman-id
commented on June 5, 2024
I can confirm this is not environment issue.
I have tried same tools version with Project IDX but still have those error.
Even with newer each tool version is still get same error.
from grpc-go.
purnesh42H
commented on June 5, 2024
@afifurrohman-id I will take a look
from grpc-go.
purnesh42H
commented on June 5, 2024
@afifurrohman-id in your server code "DoStream" function, it looks like you are panicking instead of returning error
func DoStream(cfg *Config) {
stream, err := cfg.client.Stream(cfg.ctx)
if err != nil {
panic(err)
}
defer stream.CloseSend()
const max = 10
for i := 1; i <= max; i++ {
if err := stream.Send(new(emptypb.Empty)); err != nil {
panic(err)
}
res, err := stream.Recv()
if err == io.EOF {
break
}
if err != nil {
panic(err)
}
fmt.Println("stream create recv: ", res)
}
cfg.wait <- struct{}{}
}
It's generally recommended to avoid using panic for error handling and instead propagate errors up the call stack using return values instead of panicking. Panics can indirectly affect context cancellation by terminating goroutines and their associated cleanup logic.
Can you try returning the errors from server (refer RouteChat example) and log at client side. Also, share both server and client logs
from grpc-go.
Related Issues (20)
- feature: `protoc-gen-go-grpc` to create test client / `bufconn` constructors HOT 2
- Flaky test: TestClientSendsAGoAway HOT 8
- Catching grpc connection configuration errors at startup HOT 2
- CloseSend immediately after Send
- Minor 'invalid code' error output suggestion
- advancedtls package does not set VerifiedChains in TLSInfo.State HOT 5
- Delayed dns resolve after upgrade to v1.60.0 HOT 5
- channelz: SubChannel do not report their Target properly since 1.63 HOT 1
- xds: support LRS for all cluster types HOT 4
- Updating credentials of a running server HOT 5
- clusterimpl: update picker synchronously upon receipt of configuration update HOT 1
- cds: update picker synchronously upon receipt of configuration update
- rls: update picker synchronously upon receipt of configuration update
- Improve grpc-go/Documentation to clearly specify usage of `grpc.SetTrailer` function for adding metadata to send to client
- New ServerOption to set cancel insensitive "values" context. HOT 1
- Return the actual error from unary RPCs when `SendMsg()` returns `io.EOF` HOT 10
- protoc-gen-go-grpc: copy service comment to interfaces HOT 2
- Deprecate Dial and DialContext through a mechanism that doesn't trigger linters HOT 1
- Flaky test: 6/100K: Test/LRSClient HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-go.