Giter VIP home page Giter VIP logo

Comments (2)

mantkiew avatar mantkiew commented on August 15, 2024

My first stab at implementing it reveals a few problems, the biggest one being that I would have to change the analyses to always keep track of the whole inheritance hierarchy of a clafer to determine valid nesting and generate correct output. Currently, the code generated for left is incorrect:

one sig c0_CptHook extends c0_Person
{ r_c0_left : one c0_left
, r_c0_right : one c0_right }
{ r_c0_right in r_c0_Hand }

The correct code should be

one sig c0_CptHook extends c0_Person
{ r_c0_left : one c0_left
, r_c0_right : one c0_right }
{ r_c0_left in r_c0_Hand
  r_c0_right in r_c0_Hand }

The reason that the constraint r_c0_left in r_c0_Hand is missing now is because in order to generate it one must go up to Person, which defines Hand but we only go to Hook, which does not have a parent.

There's onc trick we could do: always interpret abstract top-level clafers which extend nested abstract clafers as actually their siblings. So, our example would actually be represented in IR as

abstract Person
    abstract Hand
    abstract Hook : Hand

that is the real semantics of allowing to define abstract Hook : Hand as a top-level. Doing so, will not require any changes to code analysis nor code generation. It's a simple transformation that can be done after unique ids are generated. The positive is that desugared clafer will show that semantics.

from clafer.

mantkiew avatar mantkiew commented on August 15, 2024

Implementation. We execute the transformation in two phases:

  1. in ResolverInheritance.resolveNClafer, we change the parentUID of a top-level abstract clafers to point to the parent of their superClafer. This makes these clafers logically siblings of their super.
  2. in ResolverInheritance.relocateTopLevelAbstractToParents, we physically move the top-level clafers to their respecitive parents. This makes these clafers physically siblings of their super.

from clafer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.