Comments (11)
Bummer.
We'll probably have to resort to some code duplication, remove the generic Object<T>
struct and make each type its own newtype. Possibly using a macro like rgtk did.
Another problem is that even with that out of the way rustdoc won't show that e.g. PixbufAnimation
and PixbufSimpleAnim
implement PixbufAnimationExt
and I'm not sure how to fix this. Just reference the applicable traits in the doc comments?
This is not a big deal in gdk but will be a problem in gtk, so thanks for bringing this up before I made all of gtk like this :)
from gdk.
@jashephe
I see you've already identified one or more relevant open issues in the rust repo. Could you link them here?
from gdk.
@gkoz, I'm not sure what you mean. I haven't seen a relevant rustdoc issue, I just assumed that rustdoc was to blame.
from gdk.
I thought I saw your comment in one of rustdoc issues...
from gdk.
Ah, that was actually for a different, but perhaps related issue. The implementation of ContextExt
for Context
is not shown in the documentation for rust-gnome/gdk, because Context
is not part of the gdk crate. I was able to get around it by documenting the ContextExt
trait method definitions, rather than the implementing methods.
from gdk.
Here's that issue, but it's not quite the same as what's going on here.
from gdk.
The type aliases issue: rust-lang/rust#19381
The blanket impls issue: rust-lang/rust#25608
I'm hopeful this can be fixed in rustdoc rather than by hoop-jumping.
from gdk.
It doesn't look like either of those issues has received much attention, unfortunately.
from gdk.
@gkoz, did your pull request (rust-lang/rust#25892) fix this issue? Why exactly was it closed?
from gdk.
That was a hack that didn't get much support because of the limitations of a 10-line patch.
It wouldn't buy us much anyway and could be worked around. The big stopper is rust-lang/rust#25608 (possibly with added transitivity requirement) because most of the invisible documentation would be of the impl <O: Upcast<Window>> WindowExt for O
kind.
from gdk.
Inherent implementations should be visible now. The blanket implementations issue probably requires rewriting rustdoc.
from gdk.
Related Issues (20)
- Any way to get XID from Window/DrawingArea? HOT 13
- Missing keymaps HOT 3
- add a method get_root_position() to EventMotion HOT 2
- Bindings for gdk_event_request_motions() missing HOT 1
- Events are missing properties HOT 6
- `Event::downcast` is requires clone from event handler HOT 2
- Proposal: use an `Option` for return value of `get_[predicted_]presentation_time()` HOT 3
- setting _NET_WM_WINDOW_TYPE(ATOM) HOT 2
- get window title HOT 1
- Window function set_titlebar generate gtk-CRITICAL error messages when moving window HOT 2
- gdk::Seat::grab() panic HOT 4
- Compilation failing HOT 2
- Clean up ciaro interactions HOT 4
- Missing gdk_key_map_* functions
- GdkPixbufExt: create_surface doesn't work with a None HOT 5
- Add GDK_EVENT_* & GDK_BUTTON_* to the public api HOT 2
- Use of gdk_sys::gdk_screen_get_default() HOT 2
- gdk::WindowAttr should contain an EventMask in the event_mask field
- Nicer bindings for Key(val) related functions HOT 1
- unresolved import `gdk::Monitor` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdk.