threads_add_idle asserts it is running on the main thread about gtk3-rs HOT 9 CLOSED

Yeah, we're just going to remove the functions :) They're only duplicating the behaviour of the functions with the same names from glib.

from gtk3-rs.

I also just ran into this.

Not only is this function safe to call from other threads, it is the recommended way of communicating back to the main thread from another thread.

I'd be happy to come up with a patch, but I'm not sure how that works with the generated bindings?

from gtk3-rs.

@cmyr: So issue need be renamed to "threads_add_idle asserts if is running not on the main thread" ?

from gtk3-rs.

It need fix in gir, I will do it on the weekend

from gtk3-rs.

@cmyr You can use glib::source::idle_add(), or for a slightly different pattern glib::MainContext::channel() or any approach using futures (the main context is a futures executor).

I think we should simply ignore this and similar functions from gdk. They don't bring any additional advantage.

from gtk3-rs.

I think we should simply ignore this and similar functions from gdk. They don't bring any additional advantage.

I.e. all gdk_threads_.* functions should be ignored.

from gtk3-rs.

@EPashkin You make a PR for that?

from gtk3-rs.

idle_add() looks like it would probably work. I don't have enough context to offer a strong opinion; I don't use gtk much, I'm just maintaining some code.

In terms of naming of this thread title, well lets not spend too much time on it 😉 but I think the current phrasing is reasonable; there is an assert that checks if the function is running on the main thread, which fails otherwise, even though it should be okay to call this function on other threads.

from gtk3-rs.

The functions were removed.

from gtk3-rs.