Comments (10)
As a first step this needs some documenting of the impact of this. Apart from switching the default branch in git, what is assuming a branch named "master"?
Probably the CI scripts, probably @GuillaumeGomez's release scripts. What else?
Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?
from release.
Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?
https://github.com/github/renaming/ sounds like github got us covered for many things.
Some background information https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/. Looks like main will be the default in the majority of place pretty soon. Maybe it's less pain to do the change now.
from release.
The default branch for cargo is master
. Another thing to be taken into account (for our end users).
from release.
The default branch for cargo is
master
. Another thing to be taken into account (for our end users).
The branch for cargo new
depends on init.defaultBranch
. Support for using the remotes default branch is only waiting for a release I guess https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-152-2021-05-06.
from release.
Not for new projects, for projects using gtk-rs
as a dependency.
from release.
Not for new projects, for projects using
gtk-rs
as a dependency.
Yes I answered this in my comment too. Also, this change will probably be transparent for end users because GitHub redirects the branch https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/ (also mentioned before.)
from release.
Oh indeed, well, that's one less concern then.
from release.
Progress with Rust 1.53
Cargo no longer assumes the default HEAD of git repositories is named master. This means you no longer need to specify branch = "main" for git dependencies from a repository where the default branch is called main.
https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html#head-branch-name-support-in-cargo
from release.
Should we then maybe do it before the release now? :) @GuillaumeGomez @bilelmoussaoui ?
from release.
Sounds good to me
from release.
Related Issues (20)
- Don't forget to copy aliases.js files if they get added
- Tags don't work well in the same repository
- lgpl-docs publication HOT 1
- Fix search-index.js generation HOT 1
- Release script didn't update examples Cargo.toml versions correctly
- Do next release with all crates at the same version HOT 1
- New release HOT 1
- New release HOT 4
- Project icon HOT 39
- Generate all docs with the same output folder
- Remove documentation generation HOT 1
- Agree on stability statement for crates HOT 7
- Change release script execution order
- Change how script gets "oldest date" when looking for PRs for the blog post
- New release HOT 1
- When a dependency has a git url and a version, the version is generated twice in the output
- New release HOT 2
- New release
- Building a cargo vet infrastructure HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from release.