Giter VIP home page Giter VIP logo

Comments (10)

sdroege avatar sdroege commented on August 22, 2024

As a first step this needs some documenting of the impact of this. Apart from switching the default branch in git, what is assuming a branch named "master"?

Probably the CI scripts, probably @GuillaumeGomez's release scripts. What else?

Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?

from release.

sophie-h avatar sophie-h commented on August 22, 2024

Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?

https://github.com/github/renaming/ sounds like github got us covered for many things.

Some background information https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/. Looks like main will be the default in the majority of place pretty soon. Maybe it's less pain to do the change now.

from release.

GuillaumeGomez avatar GuillaumeGomez commented on August 22, 2024

The default branch for cargo is master. Another thing to be taken into account (for our end users).

from release.

sophie-h avatar sophie-h commented on August 22, 2024

The default branch for cargo is master. Another thing to be taken into account (for our end users).

The branch for cargo new depends on init.defaultBranch. Support for using the remotes default branch is only waiting for a release I guess https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-152-2021-05-06.

from release.

GuillaumeGomez avatar GuillaumeGomez commented on August 22, 2024

Not for new projects, for projects using gtk-rs as a dependency.

from release.

sophie-h avatar sophie-h commented on August 22, 2024

Not for new projects, for projects using gtk-rs as a dependency.

Yes I answered this in my comment too. Also, this change will probably be transparent for end users because GitHub redirects the branch https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/ (also mentioned before.)

from release.

GuillaumeGomez avatar GuillaumeGomez commented on August 22, 2024

Oh indeed, well, that's one less concern then.

from release.

sophie-h avatar sophie-h commented on August 22, 2024

Progress with Rust 1.53

Cargo no longer assumes the default HEAD of git repositories is named master. This means you no longer need to specify branch = "main" for git dependencies from a repository where the default branch is called main.

https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html#head-branch-name-support-in-cargo

from release.

sdroege avatar sdroege commented on August 22, 2024

Should we then maybe do it before the release now? :) @GuillaumeGomez @bilelmoussaoui ?

from release.

bilelmoussaoui avatar bilelmoussaoui commented on August 22, 2024

Sounds good to me

from release.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.