Giter VIP home page Giter VIP logo

Comments (2)

billwanjohi avatar billwanjohi commented on June 29, 2024 1

You are correct that the new variable name is hosted_zone_id, which is more accurate, but still has a poor description. The change happened in 7f3e6c2, which was included in tag 1.20.1.

For people suprised by this new behavior, you can either pin yourself to an older version

source = "Guimove/bastion/aws"
version = "1.2.0"
hosted_zone_name = ...

or bump the required version and rename the variable

source = "Guimove/bastion/aws"
version = "~> 1.2.1"
hosted_zone_id = ...

@Guimove if at all possible when you're releasing breaking changes like this in the future, can you bump the major version? That way users like ourselves can benefit from non-breaking changes but hold off on any that will require revisions in our code.

(Thanks for putting together this module, it is very handy!)

from terraform-aws-bastion.

Guimove avatar Guimove commented on June 29, 2024

Hello,

Sorry, I've created a new 2.0.0 version for all these new major changes.

from terraform-aws-bastion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.