Comments (9)
guitargeek
commented on August 22, 2024
Hi, you use an older version of CMake that does not yet support the DESCRIPTION parameter in project, so it gets confused. Since this DESCRIPTION is not really needed, I just got rid of it: in the latest commit 8b7549d.
Is it working for you like that?
from xgboost-fastforest.
mtpadilla
commented on August 22, 2024
Hello, and thank you for following up. I pulled the update and it produces a make file, but does so with an error:
[[email protected] build]$ cmake ..
-- The C compiler identification is GNU 4.4.7
-- The CXX compiler identification is GNU 4.4.7
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost version: 1.41.0
-- Found the following Boost libraries:
-- system
-- filesystem
-- unit_test_framework
-- Configuring done
CMake Error at CMakeLists.txt:19 (add_library):
CXX_STANDARD is set to invalid value '17'
CMake Error at test/CMakeLists.txt:6 (add_executable):
CXX_STANDARD is set to invalid value '17'
-- Generating done
-- Build files have been written to: /disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/build
[[email protected] build]$
trying to make then fails. Please refer to the attached log.
from xgboost-fastforest.
guitargeek
commented on August 22, 2024
I see, your old compiler does not support C++17 yet. XGBoost-FastForest does not really need these features, so I adapted it such that it requires only C++11. Everyone should have that by now.
Let me know if you have further problems!
from xgboost-fastforest.
mtpadilla
commented on August 22, 2024
Hi Jonas. Thanks again for the reply. Almost there...getting closer. That solved the cmake issue but am now having an issue with running make:
(blah blah)
-- Build files have been written to: /disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/build
[[email protected] build]$ make
Scanning dependencies of target fastforest
[ 16%] Building CXX object CMakeFiles/fastforest.dir/src/common_details.cpp.o
[ 33%] Building CXX object CMakeFiles/fastforest.dir/src/fastforest.cpp.o
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:35:35: error: experimental/filesystem: No such file or directory
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:55: error: ISO C++ forbids initialization of member ‘value’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:55: error: making ‘value’ static
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:56: error: ISO C++ forbids initialization of member ‘found’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:56: error: making ‘found’ static
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:56: error: ISO C++ forbids in-class initialization of non-const static member ‘found’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:57: error: ISO C++ forbids initialization of member ‘failed’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:57: error: making ‘failed’ static
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:57: error: ISO C++ forbids in-class initialization of non-const static member ‘failed’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp: In function ‘fastforest::FastForest fastforest::load_txt(const std::string&, std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)’:
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:97: error: ‘std::experimental’ has not been declared
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp: At global scope:
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp: In instantiation of ‘<unnamed>::util::NumericAfterSubstrOutput<int>’:
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:159: instantiated from here
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:55: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<int>::value’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:56: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<int>::found’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:57: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<int>::failed’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp: In instantiation of ‘<unnamed>::util::NumericAfterSubstrOutput<float>’:
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:180: instantiated from here
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:55: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<float>::value’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:56: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<float>::found’
/disk1/mpadilla/projects/conf_eng/XGBoost-FastForest/src/fastforest.cpp:57: error: ISO C++ forbids in-class initialization of non-const static member ‘<unnamed>::util::NumericAfterSubstrOutput<float>::failed’
make[2]: *** [CMakeFiles/fastforest.dir/src/fastforest.cpp.o] Error 1
make[1]: *** [CMakeFiles/fastforest.dir/all] Error 2
make: *** [all] Error 2
[[email protected] build]$ g++ --version
g++ (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[[email protected] build]$
from xgboost-fastforest.
guitargeek
commented on August 22, 2024
Hi Michael, that is really a super old gcc! I give you the benefit of the doubt and hope that it's not in your hands that the environment is so outdated...
I made fastforest now comply with the outdated ISO standard, it should compile now for you. Let me know if you still have troubles.
from xgboost-fastforest.
guitargeek
commented on August 22, 2024
Also, let me know if it compiles now so the issue can be closed.
from xgboost-fastforest.
mtpadilla
commented on August 22, 2024
Hi Jonas. Thank you again for the update and mail. I'm trying to get my system updated (a bit complicated as much of it is indeed out of my control) a bit since more errors arose. Please give me a day or two to do what I can and I'll definitely follow-up...
from xgboost-fastforest.
guitargeek
commented on August 22, 2024
Hello, I'll close this issue, because the original issue with cmake was solved anyway. Afterwards, we were discussing more about old C++ standard compatibility, so it was actually a new issue. Please open a new issue about this if this is still relevant.
from xgboost-fastforest.
mtpadilla
commented on August 22, 2024
Hi Jonas. Sounds great and will do. Will open new tickets if/when necessary. Vielen Dank für Ihre Hilfe.
from xgboost-fastforest.
Related Issues (20)
- GCC version requirements？ HOT 7
- Undefined reference to fastforest HOT 2
- Linking error for build C++ test HOT 3
- std::length_error issue HOT 4
- Cannot handle a multi-class model containing a tree with a single leaf node? HOT 1
- Difficulty reproducing benchmarks HOT 3
- C++ 98 Compatibility/Feasibility HOT 7
- Executing Test(s) Issue HOT 1
- C++98 Compatibility HOT 4
- XGBoost regression HOT 1
- Results of binary logistic regression mismatched with xgboost HOT 6
- FastForest inference decripincies with XGBoost HOT 7
- Prediction and Scores are not the same in Python and C++ (cannot reproduce results) HOT 1
- Different confidence score between FastForest and predict_proba of python? HOT 11
- XGBoost and FastForest predictions don't match HOT 11
- gcc version HOT 2
- Trying to add project in cmake HOT 6
- multiclass support HOT 4
- make issue when build test.cpp.o HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xgboost-fastforest.