Favicon stack trace about pastefile HOT 5 CLOSED

Do you think we should fix it by ignoring all query "GET /favicon.ico" or simply by providing the file ?

from pastefile.

Hum, start to ignore (CF #5 issue).

from pastefile.

in fact, every query that are not handled by the application cause the server to return a 500 error instead of a 404 error

from pastefile.

12:11:22 ✔ guits@elisheba:~$ curl -o/dev/null -D- -s -XGET http://pastefile.fr/foo
HTTP/1.1 500 INTERNAL SERVER ERROR
Server: nginx
Date: Thu, 05 Nov 2015 11:12:00 GMT
Content-Type: text/html
Content-Length: 291
Connection: keep-alive

12:11:27 ✔ guits@elisheba:~$ curl -o/dev/null -D- -s -XGET http://pastefile.fr/foo/
HTTP/1.1 404 NOT FOUND
Server: nginx
Date: Thu, 05 Nov 2015 11:12:02 GMT
Content-Type: text/html
Content-Length: 233
Connection: keep-alive

12:11:29 ✔ guits@elisheba:~$ curl -o/dev/null -D- -s -XGET http://pastefile.fr/foo/bar
HTTP/1.1 404 NOT FOUND
Server: nginx
Date: Thu, 05 Nov 2015 11:12:07 GMT
Content-Type: text/html
Content-Length: 233
Connection: keep-alive

12:11:34 ✔ guits@elisheba:~$

from pastefile.

fixed in b522173

 @app.route('/<id_file>', methods=['GET'])
 def get_file(id_file):
     with JsonDB(app.config['file_list']) as db:
-        filename = db.db[id_file]['storage_full_filename']
-        print filename
-        return send_from_directory(app.config['upload_folder'],
-                                   os.path.basename(filename))
+        if id_file in db.db:
+            filename = db.db[id_file]['storage_full_filename']
+            return send_from_directory(app.config['upload_folder'],
+                                       os.path.basename(filename))
+        else:
+            return abort(404)```

from pastefile.