Giter VIP home page Giter VIP logo

Comments (12)

branan avatar branan commented on August 19, 2024

This is mostly done at this point - plClient and a couple of other apps are converted, along with the max plugin. Someone should probably play with the remaining apps at some point, just so we can finally close this thing

from plasma.

Hoikas avatar Hoikas commented on August 19, 2024

I think the only remaining blocker on this is plSDLBrowser

from plasma.

branan avatar branan commented on August 19, 2024

Awesome. It'll be nice to finally close #1

from plasma.

Mystler avatar Mystler commented on August 19, 2024

I tried to write a CMake file for it once but I encountered either a problem with missing files or one with outdated code.

from plasma.

Lunanne avatar Lunanne commented on August 19, 2024

Some of the code files were removed in an old commit as they were unused at the time. I'm planning to try to get it to work later today.

Edit : it seems some files needed were removed for licence issues, namely https://bitbucket.org/Lunanne/cwe-ou/src/d2e5b9c38803/MOULOpenSourceClientPlugin/Plasma20/Sources/Plasma/PubUtilLib/plWndCtrls/basewnd.h

from plasma.

Deledrius avatar Deledrius commented on August 19, 2024

Did you make any progress on that, @Lunanne, or should I take a stab at it?

from plasma.

Lunanne avatar Lunanne commented on August 19, 2024

I haven't really looked again, I got distracted and I don't really know enough c++ yet to solve the issue anyway.

from plasma.

Deledrius avatar Deledrius commented on August 19, 2024

It appears to have been commit 971c39d which removed those files due to a dependency upon a library with no license (at least none that I can see on http://www.mvps.org/user32/), but the plWndCtrls code itself should have been fine...? It seems the code on which it depended was a very simple collection of functions to replace, too, but it was all unused at the time since plSDLBrowser was not active.

Do we even need to resurrect plSDLBrowser? Looking at this thing, it appears pretty simple and ugly, and depends on a load of gunk used nowhere else.

from plasma.

branan avatar branan commented on August 19, 2024

My thoughts here:

Is there a need for this sort of tool in the community? If so we either need to fix this or write a replacement. If there's no present need it should be trashed and only looked at again if we have a need that this tool (or something like it) could fill.

from plasma.

branan avatar branan commented on August 19, 2024

gah, freeking close and comment is not awesome on un-css'd browsers :(

from plasma.

Lunanne avatar Lunanne commented on August 19, 2024

I'm currently trying to get the project to build to see what it exactly does, probably anyone else can do this a lot faster than me but it is a good exercise.

from plasma.

Lyrositor avatar Lyrositor commented on August 19, 2024

IRC discussion has led to the consensus that plSDLBrowser should be tossed, because it is useless as it is and can't work because of removed copyrighted Microsoft code. I'll try to make a PR removing it.

from plasma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.