Giter VIP home page Giter VIP logo

Comments (2)

giannik avatar giannik commented on August 15, 2024 1

I verify that it works. For some reason i had it there before moving from jquery validation

from aspnet-client-validation.

dahlbyk avatar dahlbyk commented on August 15, 2024

The validation failure is caused by this:

<input asp-for="PartSelections[i].IsSelected" type="hidden" />

You don't need to explicitly include that; asp-for automatically appends a hidden input to the form.

I've added a demo to reproduce: #72. Without the explicit hidden the markup looks like this:

<form method="post">
        <div class="form-field">
                <label>
                    <input type="checkbox" data-val="true" data-val-required="The IsSelected field is required." id="Numbers_0__IsSelected" name="Numbers[0].IsSelected" value="true" class="input-validation-valid">
                    One
                </label>
                <input type="hidden" data-val="true" data-val-required="The Name field is required." id="Numbers_0__Name" name="Numbers[0].Name" value="One" class="input-validation-valid">
                <!-- snip -->
            <span class="field-validation-valid" data-valmsg-for="Numbers" data-valmsg-replace="true"></span>
            <em class="results">Selected numbers: </em>
        </div>

        <input type="submit" value="Submit">
    <input name="__RequestVerificationToken" type="hidden" value="...">
    <input name="Numbers[0].IsSelected" type="hidden" value="false" class="input-validation-valid">
    <input name="Numbers[1].IsSelected" type="hidden" value="false" class="input-validation-valid">
    <input name="Numbers[2].IsSelected" type="hidden" value="false" class="input-validation-valid">
</form>

Including it adds an extra hidden that's confusing us:

                <input type="hidden" id="Numbers_0__IsSelected" name="Numbers[0].IsSelected" value="False" class="input-validation-valid">

Specifically we're confused by "False" instead of the auto-generated false:

aspnet-client-validation/src/index.ts

Lines 138 to 146 in ed09a05

// Checkboxes do not submit a value when unchecked. To work around this, platforms such as ASP.NET render a
// hidden input with the same name as the checkbox so that a value ("false") is still submitted even when
// the checkbox is not checked. We check this special case here.
if (elementType === "checkbox") {
const checkboxHiddenInput = element.form.querySelector(`input[name='${element.name}'][type='hidden']`);
if (checkboxHiddenInput instanceof HTMLInputElement && checkboxHiddenInput.value === "false") {
return true;
}
}

We could certainly patch that to also allow "False", but that's not necessary for the standard pattern to Just Work.

from aspnet-client-validation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.