Comments (30)
I would like to take the portal jsx file in work
from react-datepicker.
@martijnrusschen can you pin the issue?
from react-datepicker.
Nice progress so far!
from react-datepicker.
@yuki0410-dev Feel free to claim a file and let it know here so there's no duplicate work done.
from react-datepicker.
@yuki0410-dev hello
Yes, grab anything, the only one piece of advice is to pick modules without dependencies or with dependencies only on typescript modules, because it won't be pleasant to combine them later
from react-datepicker.
I would like to take the week_number.jsx file in work
from react-datepicker.
Added your name to week_number.jsx
from react-datepicker.
6.6% 💪
from react-datepicker.
@mirus-ua
I would like to take the year_dropdown.jsx and year_dropdown_options.jsx file in work.
from react-datepicker.
@mirus-ua
I would like to take the month_dropdown.jsx and month_dropdown_options.jsx file in work.
from react-datepicker.
Yep, I'll expect them to complete this soon. Normal turnaround time is ~2-4 hours.
from react-datepicker.
@mirus-ua
I would like to take the time.jsx file in work.
from react-datepicker.
@mirus-ua I would like to take the year.jsx file in work.
from react-datepicker.
@mirus-ua
I would like to take the popper_component.jsx file in work.
from react-datepicker.
@mirus-ua Modifications to index.jsx may need to be synchronized with modifications to calendar.jsx. (especially the props type) Would it be ok if I work on it all together?
sure, I think you should wait a bit for the month and the year modules
from react-datepicker.
sure, I think you should wait a bit for the month and the year modules
I agree with waiting too.
We are moving forward on the calendar.jsx work, but there are some aspects that we cannot move forward on until those are completed.
from react-datepicker.
@yuki0410-dev almost everything was merged, so you can start with the final part
from react-datepicker.
what's left?
from react-datepicker.
@mirus-ua (@martijnrusschen )
I would like to take the week_picker_test.test.js file in work. and fix some types.
from react-datepicker.
@mirus-ua I noticed during my experimentation with #4810 that type errors in the test file do not seem to result in errors in CI. Is it my understanding that this is due to the fact that I am now using babel-jest to run tests with type information ignored, and that when I change to ts-jest later on, I will get CI errors?
everything is correct
from react-datepicker.
@mirus-ua ( @martijnrusschen )
Thank you for the great attempt.
I would like to help as well, but should I declare the file to be started on this issue?
from react-datepicker.
refs #4000
from react-datepicker.
@martijnrusschen hello. Please ask reviews to look at four opened PRs if you can. It'll be much faster if we merge them because the rest of the modules depend on them
from react-datepicker.
@mirus-ua
I would like to take the month_year_dropdown.jsxand month_year_dropdown_options.jsx file in work.
from react-datepicker.
@mirus-ua
I would like to take the week.jsx file in work.
from react-datepicker.
@mirus-ua
I would like to take the calendar.jsx file in work.
from react-datepicker.
@mirus-ua
Modifications to index.jsx may need to be synchronized with modifications to calendar.jsx. (especially the props type)
Would it be ok if I work on it all together?
from react-datepicker.
from react-datepicker.
what's left?
The core features are done.But I think better to migrate some amount of tests just to double check that all types are OK
from react-datepicker.
@mirus-ua
I noticed during my experimentation with #4810 that type errors in the test file do not seem to result in errors in CI.
Is it my understanding that this is due to the fact that I am now using babel-jest to run tests with type information ignored, and that when I change to ts-jest later on, I will get CI errors?
from react-datepicker.
Related Issues (20)
- Keyboard not working when showTimeSelectOnly is True HOT 1
- Accessibility: Headings HOT 1
- ./node_modules/date-fns/startOfISOWeek.mjs Can't import the named export 'startOfWeek' from non EcmaScript module (only default export is available)
- ./node_modules/date-fns/startOfISOWeek.mjs HOT 1
- MonthYearPicker: Excluded/Disabled Months are able to be navigated to with keyboard HOT 3
- Make date range separator customizable
- dayClassName runs even on hover and loops on every date making the datepicker rendering slower.
- "renderYearContent" unavailable in proptypes HOT 1
- Error using time select HOT 6
- Error when installing dependencies
- Gap between arrow and the datepicker HOT 1
- Datepicker onChange event type Error when selectsRange prop is true HOT 1
- SelectsMultiple with DateTime or TimeOnly
- Click outside day of month then React DatePicker auto close, can't not select end date?
- Accessibility: Navigation options within react-datepicker not adequately relayed to screen reader
- Accessibility: Button Contrast
- Can't import the named export 'startOfWeek' from non EcmaScript module (only default export is available)
- onclickoutside not working with react 19 in datepicker
- TypeError after upgrading to 5.0.0
- Is the calendar accessible to screen readers? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-datepicker.