Giter VIP home page Giter VIP logo

Comments (1)

jackycute avatar jackycute commented on August 15, 2024

Fixed in 5467e6d and db324c5

Cookie not set is cause by session saveUninitialized was set to false.
https://github.com/hackmdio/hackmd/blob/master/app.js#L99
And that mean user might not have cookie before doing anything.

Cookie can always authorize success is cause by a bug in the statement.
https://github.com/hackmdio/hackmd/blob/master/lib/realtime.js#L52
If handshakeData.sessionID or handshakeData.cookie[config.sessionname] be undefined, they won't be equal and should check before comparison.

from codimd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.