Comments (1)
👋 I'm not really sure what the intent is here with the new suggested copy -- the current copy seems to me to correctly convey the rules for PRs that qualify:
PRs count if:
Submitted during the month of October AND
Submitted in a public repo AND (
The PR is labelled as hacktoberfest-accepted by a maintainer OR
Submitted in a repo with the hacktoberfest topic AND (
The PR is merged OR
The PR has been approved
)
)
Any PR (merged, open, closed) can be "accepted" by adding the hacktoberfest-accepted
label to it, so the Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.
copy conveys this correctly, there is no requirement to merge etc.
The alternative is that the repository must have the hacktoberfest
topic applied, with the PR then being merged or approved. The copy correctly conveys the requirement for the topic: Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate.
This copy does not convey the requirement for the PR to be merged/approved, as once the repository has the topic applied an unmerged PR will transition to the pending state, where the copy for that state clearly conveys the requirement: Your PR has not yet been accepted by a maintainer. A maintainer can accept your PR by merging it, adding the "hacktoberfest-accepted" label to it, or approving it.
.
from hacktoberfest-2020.
Related Issues (20)
- Do's and Don'ts cards text is hard to read on Dark Mode HOT 1
- Info-pane on the profile page of site not readable. HOT 3
- [BUG] - "Bonus Box" div invisible on light mode
- Slight changes in the Contributing.md HOT 1
- More than 4 pull requests doesn't have a plus icon in light mode HOT 1
- Events page add "viewless" in the website HOT 3
- Update Profile button issues in website
- Add HackMD badge to README.md HOT 1
- Linkedin,Facebook logos hyper links are missing in the website HOT 2
- Article on Hacktoberfest2020 in Linkedin HOT 1
- Add Digitalocean Blog in Navbar of UI in the website HOT 1
- Profile page margin-top issue on main content HOT 3
- Maintain a Dashboard for all the Pull Request of Hackatoberfest2020 HOT 1
- Adding Multiarch setup library feature for hacktoberfest2020 HOT 3
- Adds standard commit template for Hacktoberfest HOT 1
- PR eligibility should be sorted by maturity not submission date HOT 5
- CSS Bug in `Congratulations!`
- Pull request status not updating HOT 2
- PRs accepted by repos during Hacktoberfest now marked as "Ineligible Repository" HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hacktoberfest-2020.