Currently array!(State, 8, U8, type_for_indexes: StateIdx)</

array! u8/U8 and bytes! should use the same implementation about hacspec HOT 2 OPEN

hacspec commented on June 14, 2024

array! u8/U8 and bytes! should use the same implementation

from hacspec.

Comments (2)

denismerigoux commented on June 14, 2024

I don't quite understand this issue. bytes! is implemented as array! :

hacspec/lib/src/array.rs

Lines 912 to 916 in 2041304

 macro_rules! bytes { 

 ($name:ident, $l:expr) => { 

 array!($name, $l, U8); 

 }; 

 }

What is the different implementation you're referring to ? The only thing that's obviously false is that this line:

hacspec/lib/src/array.rs

Line 817 in 2041304

($name:ident, $l:expr, U8, $idx: ident) => {

Should rather be:

($name:ident, $l:expr, U8, type_for_indexes: $idx: ident) => {

from hacspec.

franziskuskiefer commented on June 14, 2024

Yeah, I'm not entirely sure what I'm referring to either... 😬 I think there was a function that didn't exist. Let's keep it open until we resolved #60 is resolved. If we don't find anything odd until then we can close it.

from hacspec.

array! u8/U8 and bytes! should use the same implementation about hacspec HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	macro_rules! bytes {
	($name:ident, $l:expr) => {
	array!($name, $l, U8);
	};
	}