Giter VIP home page Giter VIP logo

Comments (11)

latenitefilms avatar latenitefilms commented on June 20, 2024

Oh, and I'm still on Monterey v12.6.3 - could that be related? Did you update code to only work with Xcode on Ventura?

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

Not building the documentation (i.e. removing ./scripts/build.sh docs) builds for me. Not sure why I can't build the documentation anymore though? Any ideas @asmagill ?

from hammerspoon.

cmsj avatar cmsj commented on June 20, 2024

Where is the pip executable that you're calling? (which pip)

This could be one of the tedious things that happens when you have multiple Python installs and paths get messy.

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

/Library/Frameworks/Python.framework/Versions/3.11/bin/pip

That weird part is that I've build fine previously, and as far as I can see, nothing has changed in the build scripts since I last built, and I haven't updated Xcode, because I'm still on Monterey.

from hammerspoon.

asmagill avatar asmagill commented on June 20, 2024

In my Catalina build attempts, I've run into an issue with the Sparkle Pod not honoring the limitation to build for 10.15, so I haven't tested the doc building yet. Checking the docs for Sparkle I found one line in the release notes that talks about bumping the required Xcode version to something after the one I can run on Catalina, but no details. Still trying to learn how the pods work, maybe I could tell it to use an earlier version?

I'm thinking about stripping out Sparkle completely since we won't be using it anyways, but I was trying to keep the core files as close to the original as possible to simplify future merges. I'll poke at it some more next week.

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

As far as I can tell, it's something in here going funky:

function assert_docs_requirements() {
    # FIXME: This is overly broad - if all that's happening is linting or JSON generation, these requirements are not required
  echo "Checking Python requirements.txt is satisfied..."
  echo "import sys
import pkg_resources
from pkg_resources import DistributionNotFound, VersionConflict
dependencies = open('${HAMMERSPOON_HOME}/requirements.txt', 'r').readlines()
pkg_resources.require(dependencies)" | /usr/bin/python3
}

...any ideas @cmsj ?

from hammerspoon.

cmsj avatar cmsj commented on June 20, 2024

Yep, your pip is from a different Python than the one being used during the build (3.11 vs 3.9).

Have you run the build.sh installdeps?

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

Will try again now.

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

Ok, so I ran build.sh installdeps but now I get..

Building docs Markdown...
Traceback (most recent call last):
  File "/Users/chrishocking/Documents/GitHub/CommandPost-App/scripts/docs/bin/build_docs.py", line 835, in <module>
    main()
  File "/Users/chrishocking/Documents/GitHub/CommandPost-App/scripts/docs/bin/build_docs.py", line 829, in main
    write_markdown(arguments.output_dir + "/markdown/",
  File "/Users/chrishocking/Documents/GitHub/CommandPost-App/scripts/docs/bin/build_docs.py", line 735, in write_markdown
    write_templated_output(output_dir, template_dir, title, source_url_base, data, "md")
  File "/Users/chrishocking/Documents/GitHub/CommandPost-App/scripts/docs/bin/build_docs.py", line 662, in write_templated_output
    import markdown
ModuleNotFoundError: No module named 'markdown'

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

Ah, actually, maybe this is my fault:

	########################################################
	## ADDED BY CHRIS FOR COMMANDPOST:
	########################################################
    import jinja2
    import markdown

    md = markdown.Markdown(extensions=['meta'])

    jinja = jinja2.Environment()
    jinja.filters['markdown'] = lambda text: jinja2.Markup(md.convert(text))
    jinja.trim_blocks = True
    jinja.lstrip_blocks = True
	########################################################

from hammerspoon.

latenitefilms avatar latenitefilms commented on June 20, 2024

Adding markdown to requirements.txt solved for me!

Thanks team! Apologies for the noise.

from hammerspoon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.