Doesn't work with obsidian-modules about obsidian-run HOT 10 CLOSED

yeah. If you really need help, just feel free to arrange a call with me.

https://cal.com/manlung

from obsidian-run.

Interesting. Can you give me a code to reproduce. I cannot use your code because of the require statement

from obsidian-run.

I use the Modules plugin: https://github.com/polyipseity/obsidian-modules -- obsidian://show-plugin?id=modules.

There may be something in the codebase that gives you an indication.

from obsidian-run.

sorry, I cannot do this because because I cannot fix my plugin just to integrate with another plugin. As long as normal async function work, I will treat the feature as "complete".

from obsidian-run.

For user defined scripts, I have already support templater. You can check the readme.

from obsidian-run.

Well, it is not about "fixing" your plugin. It is about complementing as much as possible.

You are already offering the integration with Dataview -- I have not checked how complete the integration is -- and partially with Templater. Why partially? See below:

%% run start

```js
return await tp.file.include("[[test.vim]]")
``` 

%%
Loading...
%% run end %%

I am trying to include a pure text note... as soon as an await call is necessary, your plugin "hangs". Please, don't get me wrong, I am only trying to show you the "rough" edges.

from obsidian-run.

OK. I think I understand why. Sorry I didn't elaborate clearly in the doc. That is not the problem of my plugin, that is the problem of templater. because templater tp which is the internal current_functions_object is undefined unless run once. Therefore you need to set the templater at least one startup template.

see more on: https://forum.obsidian.md/t/templater-api/59117/6?u=yomaru

This issue cannot fixed by me because I have look at this already before I added the templater integration. The initialization of current_functions_object is private and other plugins has no way to call it.

I will update the doc.

from obsidian-run.

I updated the doc

from obsidian-run.

One thing I can assure that this plugin is Extremely complete. The reason why it is extremely complete is because how I write the code, I delegate the calculation to dataview and templater itself. If operation fails, it is not because of this plugin, it is because of the dataview and templater. The issues need to be opened in dataview and templater.

Obsidian Run at its core is a javascript running engine. As long as it is javascript is valid, it will be executed valid. There is no magic. And therefore it is robust.

from obsidian-run.

Noted.

I have Templater installed and active on all my devices, including one startup template, one folder template and two user scripts, which I use daily. One of my user scripts even checks and waits for Templater to be up and running before proceeding.

So all preconditions are met, but Run does not allow me to use await.

I will take some distance and maybe after a few days, I have a light bulb moment.

Keep up the good work!

from obsidian-run.