SqlServerStorage ctor should accept connection string name about hangfire HOT 8 CLOSED

This one is something that I need... as my dev and production db's are different with differing users/passwords too AFAIK. On my build script we use the appropriate string for my app.

from hangfire.

http://stackoverflow.com/a/17174533/475607

from hangfire.

Yep, thanks. I tried to write that code from my mobile phone, it was hard :) This issue intended only to simplify the initial setup.

from hangfire.

Do you need this change to be backward-compatible with the current version? SqlServerStorage has a constructor taking a single string so pretty simple to change that implementation to use the argument to fetch the matching connection string from the web.config, but that is going to suddenly break all clients in a way that will be hard for them to see (since same constructor is still in use, but semantics of its use have been altered). I'm happy to work on this as my first HangFire contribution and I know the HangFire version is less than 1.0, which typically means the API is subject to breaking changes at anytime, but want to know your thoughts. There's ways to work around the issue and leave the existing ctor as-is if that's desired.

from hangfire.

I think the ctor should take both connection string name and connection string itself, as in EntityFramework's DbContext.ctor.

from hangfire.

Ah I see, DbContext determines whether the argument is a name or a connection string and stands itself up appropriately, I didn't realize that. I'll implement it like here that and send you a PR unless someone else is already working on this.

from hangfire.

It will be great!

from hangfire.

PR #113 closes this feature.

from hangfire.