status code 418 about boom HOT 10 CLOSED

Probably because of the single quote in the value. But I agree, it's better to use single quotes for consistency, so submitted a PR.

Anyway, why do you uglify the code? This module targets node 4+ which supports template strings.

from boom.

To accommodate the single quotes I guess the I'm could be changed to I am.

I'm in the middle of updating a just completed project built in react 13 to
react 14 and started with a prebuilt account management module that used
uglify for compression. I am just trying to get it to work with the
upgrades before pulling out or changing functionality.

Thanks for the quick response!

Allan Dumaine
480 342-9045

On Mon, Dec 28, 2015 at 8:28 PM, Gergo Erdosi [email protected]
wrote:

Probably because of the single quote in the value. But I agree, it's
better to use single quotes for consistency, so submitted a PR.

Anyway, why do you uglify the code? This module targets node 4+ which
supports template strings.

—
Reply to this email directly or view it on GitHub
#96 (comment).

from boom.

How is boom related to any of that ?

from boom.

RFC 2324 defines it as "I'm a teapot", so I wouldn't change it to "I am".

https://tools.ietf.org/html/rfc2324#section-2.3.2

from boom.

Started the project with https://github.com/jedireza/aqua which uses it.

Allan Dumaine
480 342-9045

On Tue, Dec 29, 2015 at 10:21 AM, Nicolas Morel [email protected]
wrote:

How is boom related to any of that ?

—
Reply to this email directly or view it on GitHub
#96 (comment).

from boom.

Then double quotes should do it.

Allan Dumaine
480 342-9045

On Tue, Dec 29, 2015 at 10:32 AM, Gergo Erdosi [email protected]
wrote:

RFC 2324 defines it as "I'm a teapot", so I wouldn't change it to "I am".

https://tools.ietf.org/html/rfc2324#section-2.3.2

—
Reply to this email directly or view it on GitHub
#96 (comment).

from boom.

I don't see why boom would be of any use on the front end, exclude it from your build.

from boom.

Boom is for node >= 4. I used back ticks to avoid the annoying escape character.

from boom.

I think we need a style rule on that. You are using it as a backdoor to using " :-)

from boom.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from boom.