eslint 1.8 new rules about eslint-config-hapi HOT 11 CLOSED

ESLint 1.8 introduced these rules:

• arrow-body-style - I originally wanted to use this rule, set to "always", but we decided to allow implicit returns. The other setting is "as-needed", but I don't see much use for this. I talked to @hueniverse about it and it was decided that single line arrow functions can still be implemented as a normal function if you so choose. So, this rule is not much help.
• no-arrow-condition - This rule helps catch typos and bad practices, so I'm +1 for enabling this rule.

As for the new no-shadow vs no-shadow-relaxed, I'll leave that call up to @geek, as he wrote no-shadow-relaxed.

from eslint-config-hapi.

cool, will wait for @geek and then let me know if you want a PR or you prefer doing it yourself ;)

from eslint-config-hapi.

PRs are welcome. The config is in lib/index.js. Each changed rule gets a test in test/index.js based on a fixture in test/fixtures/{rule-name}.js. The test does not need to be comprehensive for the rule (that testing should be done in the rule itself).

from eslint-config-hapi.

ok will wait for @geek then ;)

from eslint-config-hapi.

@AdriVanHoudt good call, looks like we can switch to the new rule option.

from eslint-config-hapi.

@cjihrig unless you need it quicker I can only do a pr by end of the week

from eslint-config-hapi.

• Added no-arrow-condition rule in e7296ff.
• Replaced no-shadow-relaxed with no-shadow in 9cde7d9.

from eslint-config-hapi.

👍

from eslint-config-hapi.

any eta on ?

from eslint-config-hapi.

v6.0.0 has shipped. The lab PR is hapijs/lab#480

from eslint-config-hapi.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from eslint-config-hapi.