Comments (6)
AdriVanHoudt
commented on May 31, 2024
why not if (!value) or if (value === null || value === undefined) ?
from eslint-config-hapi.
cjihrig
commented on May 31, 2024
if (!value) is not strictly equivalent.
I'm personally -1 on this, but it doesn't really matter anyway. This would have to get cleared in the hapi style guide.
from eslint-config-hapi.
arb
commented on May 31, 2024
Why are you -1 on this? I agree though, this would have to go up the ladder.
from eslint-config-hapi.
cjihrig
commented on May 31, 2024
I don't like it because it is more consistent to just use === everywhere. This one exception only saves you a few characters. I think foo === undefined || foo === null is faster too.
from eslint-config-hapi.
cjihrig
commented on May 31, 2024
How about taking this up with the style guide (in hapijs/contrib I think), and if it gets OKed, I'll reopen this.
from eslint-config-hapi.
lock
commented on May 31, 2024
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.
from eslint-config-hapi.
Related Issues (20)
- Drop support for everything but Node 4 and 6 HOT 1
- Add a .npmignore file HOT 1
- Update dependencies HOT 1
- Track deprecated rules HOT 1
- Catch undeclared variables HOT 5
- validation aware eslint-config HOT 2
- Warning message during eslint-config-hapi with yarn HOT 5
- Why require-await? HOT 6
- Why no dangling commas? HOT 2
- Eslint 5 support HOT 2
- Change module namespace HOT 1
- eslint 6 support HOT 1
- Action required: Greenkeeper could not be activated 🚨 HOT 1
- Add rule: no-dupe-keys HOT 3
- Missing API file
- Rule request: key-spacing
- Update ES version
- Drop node 8 and 10
- Fix es env
- Cleanup
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-config-hapi.