Giter VIP home page Giter VIP logo

Comments (7)

cjihrig avatar cjihrig commented on May 30, 2024

I believe you're correct. Not sure if this is something we want to enforce or not. @geek thoughts? For reference - http://eslint.org/docs/rules/brace-style

from eslint-config-hapi.

AdriVanHoudt avatar AdriVanHoudt commented on May 30, 2024

see https://github.com/hapijs/contrib/blob/master/Style.md#newlines

from eslint-config-hapi.

cjihrig avatar cjihrig commented on May 30, 2024

I believe you're correct.

If @geek +1s this, I can enable it in this repo. It would constitute a major version bump in eslint-config-hapi, which is fine. However, it would also constitute a major bump in lab, which I think should be avoided right now, as v6 just recently came out. We don't want to overwhelm people with breaking changes related to linting.

from eslint-config-hapi.

AdriVanHoudt avatar AdriVanHoudt commented on May 30, 2024

every new rule here would be a major in lab, you could already implement it and then wait on more changes or something before doing a release?

from eslint-config-hapi.

geek avatar geek commented on May 30, 2024

ya, go ahead and make the change... I will wait to release

from eslint-config-hapi.

AdriVanHoudt avatar AdriVanHoudt commented on May 30, 2024

:shipit:

from eslint-config-hapi.

lock avatar lock commented on May 30, 2024

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from eslint-config-hapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.