Giter VIP home page Giter VIP logo

Comments (7)

mtharrison avatar mtharrison commented on June 10, 2024

Please try to provide the full code that we can run ourselves to confirm the issue. Otherwise we have to make guesses about everything you don't include and they could be incorrect guesses.

Here's a full example of the above that can be run: https://gist.github.com/mtharrison/eb771b4a2bace5a639c9

The above example doesn't give the 404 that you're reporting.

from glue.

mtharrison avatar mtharrison commented on June 10, 2024

I did notice if you use a port other than 80 (such as 4000), the CORS OPTIONS request will 404. This is because the following check:

https://github.com/hapijs/call/blob/master/lib/index.js#L92

It will compare example.com (the vhost setting) with example.com:4000 (the host header). It's not possible however to set the vhost option to include a port number. I'm not sure if this is a bug or not though. /cc @hueniverse

from glue.

robinvdvleuten avatar robinvdvleuten commented on June 10, 2024

@mtharrison ok the issue was indeed the port number not being port 80. But it looks like a bug in the if-statement then.

from glue.

hueniverse avatar hueniverse commented on June 10, 2024

Sounds like a bug in how the options handler sets vhost.

from glue.

mtharrison avatar mtharrison commented on June 10, 2024

I think this issue should be migrated to hapi as that's where the issue seems to lie.

from glue.

mtharrison avatar mtharrison commented on June 10, 2024

hapijs/hapi#2930

from glue.

lock avatar lock commented on June 10, 2024

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from glue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.