lookupCompressed flag does not work on directory about inert HOT 12 CLOSED

The response will only contain the gzipped file if the request has specified that gzip is ok using the accept-encoding header. Is this the case?

from inert.

Request headers does have the accept-encoding header with the values of: 'gzip, deflate, sdch'

I traced the code and until file.js internals.marshal method still had everything correct. All the necessary input was OK and seemingly grabbed the gz file, it set the proper header values etc... Once returned to the directory.js File.load(...) then it was gone and only the minified file got served back.

from inert.

from inert.

Well that sounds like a bug. Unfortunately I am unable to replicate it.

Which versions of node, hapi & inert are you using?

Are you using any specific server or connection options? Or registering other plugins?

from inert.

Actually, given that you are on Windows, this issue is likely caused by your anti-virus software, which will have modified the response before serving it to the browser.

Can you disable any such software and test again?

from inert.

Versions:
node: 5.0.0
inert: 3.2.0
hapi: 11.1.2
I added console.log(...) into this part of the code: (internals.marshal)

        response.bytes(stat.size);
        response.header('content-encoding', 'gzip');
        response.vary('accept-encoding');
        console.log(response.headers);
        return internals.openStream(response, gzFile, next);

Then I added a console.log to the onPreResponse event

server.ext('onPreResponse', function (request, reply) {
    console.log(request.response.headers);
    return reply.continue();
});

It shows what I am seeing in the browser. I disabled my anti-virus but I do not really see how can cause anything while the code running inside hapi framework.

Oh almost forgot:
connection info:

server.connection({
    port: process.env.PORT,
    host: process.env.IP,
    labels: ['site', 'saas'],
    router: {
        stripTrailingSlash: true
    },
    routes: {
        cors: true,
        validate: {
            options: {
                allowUnknown: true
            }
        }
    }
});

plugins:

plugins.push({
    register: require('hapi-swagger'),
    options: {
        documentationPath: '/restricted/docs',
        apiVersion: pkg.version
    }
});

Using dust.js (linkedin) for view engine but that would not impact how a static resource called from the rendered HTML would be found and served out.

That is all...

from inert.

The onPreResponse is as intended – The marshal phase happens after the onPreResponse hook, and before it knows that there exists a gzipped version of the file.

I still think the culprit is some local firewall (or maybe a chrome extension), which modifies the response.

from inert.

I do not think so that it has to do with firewall or chrome extension because I am running the app locally and I tried with Firefox + Firebug with the same results. I tried to use fiddler also which is very clearly shows that no compression is applied. I tried to modify the directory event handler into multiple file handlers:

        {
            method: "GET",
            path: "/styles/{filename}",
            config: {
                description: "Serve css styles",
                handler: function (request, reply) {
                    return reply.file(path.join('public/css', request.params.filename), { lookupCompressed: true });
                },
                tags: ['assets']
            }
        },
        {
            method: "GET",
            path: "/scripts/{filename}",
            config: {
                description: "Serve js scripts",
                handler: function (request, reply) {
                    return reply.file(path.join('public/js', request.params.filename), { lookupCompressed: true });
                },
                tags: ['assets']
            }
        },

This does not work either!
Is there any point I could check the response headers before it sent back? Something better then the onPreResponse hook? I want to prove that where exactly this happening...

from inert.

There is no such hook. If you want to check the headers, as it it passed onto node itself, you can grab them in hapi itself here: https://github.com/hapijs/hapi/blob/v11.1.4/lib/transmit.js#L286.

from inert.

Also, please don't use the reply.file() method without parameter validation. The ones you linked can allow access to any file on your server.

from inert.

Thanks for pointing me to the hapi.js line. It was very useful. It seems like the proper size and header information set with the expected gzip-ed result. I think you right, it might be caused by something else. (OS or anti-virus software) I will be setting up a virtual box with Linux and checking it again. As for the validation of course I will have it setup. This was just a quick way to check the results. Thanks for noting though! :)

from inert.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

from inert.