Logging about haraka HOT 4 CLOSED

Interestingly that one comes because of the global process.on('uncaughtException') which I'm thinking of getting rid of anyway...

from haraka.

Ok - but my point was shouldn't it be up to the log plugin to strip LF's or not?

As for getting rid of the uncaughtException process event; for plugins with syntax errors - it's not very useful as vm.runInNewContextContext() exceptions do not show the file and line number of the actual error despite 'name' being provided to it.

I've just modified my plugins.js to this:

try {
    vm.runInNewContext(code, sandbox, name);
}
catch (err) {
    logger.logcrit('Loading plugin ' + name + ' failed: ', err.message);
    if (config.get('smtp.ini', 'nolog', 'ini').main.ignore_bad_plugins) {
        return;
    }
    else {
        throw 'plugin_error';
    }
}

That provides much briefer output on plugin errors and is no less useful than a full stack trace:

[root@vm3 Haraka]# node haraka.js
[DEBUG] no cluster available, running single-process
Starting up Haraka version 0.9.0
[INFO] Loading plugins
[INFO] Loading plugin: stats
[CRIT] Loading plugin stats failed: Unexpected token .
[CRIT] Caught exception: plugin_error
[CRIT] Server not ready yet. Stopping.

from haraka.

+1. No line breaks makes errors extremely difficult to read.

from haraka.

Please try 1.0.0. Closing this issue for now.

from haraka.