Giter VIP home page Giter VIP logo

Comments (9)

tskaufma avatar tskaufma commented on September 14, 2024

I've found in the latest build the package.json says the main is "app.js" when there is no such file. I copied lib\riot-games-api-nodejs.js to app.js and it seems to work.

Hope that helps.

from riot-games-api-nodejs.

emilabraham avatar emilabraham commented on September 14, 2024

That did it for me. I'm gonna make a pull request. However, I also found that pointing the main to "./lib/riot-games-api-nodejs.js" also works. Which do you think would better follow the standards, @tskaufma? Your change or the change I tried?

from riot-games-api-nodejs.

tskaufma avatar tskaufma commented on September 14, 2024

I think your change would be better as a PR since it doesn't duplicate the code file. I don't know about best practices.

from riot-games-api-nodejs.

emilabraham avatar emilabraham commented on September 14, 2024

Pull request merged. That should solve the issue.

from riot-games-api-nodejs.

byWulf avatar byWulf commented on September 14, 2024

@emilabraham Hey :) When will this change be in a stable release for install via npm?

from riot-games-api-nodejs.

emilabraham avatar emilabraham commented on September 14, 2024

Paging @HardTacos as he is the publisher of the official npm module.

from riot-games-api-nodejs.

Dowdow avatar Dowdow commented on September 14, 2024

Hello ! This change is not on the stable release. Is this repository still maintained ?

from riot-games-api-nodejs.

amcd1443 avatar amcd1443 commented on September 14, 2024

bump still not merged into stable

from riot-games-api-nodejs.

HardTacos avatar HardTacos commented on September 14, 2024

changes have been published to npm.

from riot-games-api-nodejs.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.