Comments (9)
I've found in the latest build the package.json says the main is "app.js" when there is no such file. I copied lib\riot-games-api-nodejs.js to app.js and it seems to work.
Hope that helps.
from riot-games-api-nodejs.
That did it for me. I'm gonna make a pull request. However, I also found that pointing the main to "./lib/riot-games-api-nodejs.js" also works. Which do you think would better follow the standards, @tskaufma? Your change or the change I tried?
from riot-games-api-nodejs.
I think your change would be better as a PR since it doesn't duplicate the code file. I don't know about best practices.
from riot-games-api-nodejs.
Pull request merged. That should solve the issue.
from riot-games-api-nodejs.
@emilabraham Hey :) When will this change be in a stable release for install via npm?
from riot-games-api-nodejs.
Paging @HardTacos as he is the publisher of the official npm module.
from riot-games-api-nodejs.
Hello ! This change is not on the stable release. Is this repository still maintained ?
from riot-games-api-nodejs.
bump still not merged into stable
from riot-games-api-nodejs.
changes have been published to npm.
from riot-games-api-nodejs.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riot-games-api-nodejs.