Giter VIP home page Giter VIP logo

Comments (3)

HardySimpson avatar HardySimpson commented on August 19, 2024

Yes, you are right. I fix it and launch zlog 1.2.2....

from zlog.

HardySimpson avatar HardySimpson commented on August 19, 2024

The last fix is not correct, simplely kick the cache will cause sometimes not fetch time. so I fix it again....

I think this fix will work, isn't it ?

static int zlog_spec_write_time(zlog_spec_t * a_spec, zlog_thread_t * a_thread, zlog_buf_t * a_buf)
{
        if (!a_thread->event->time_stamp.tv_sec) {
                gettimeofday(&(a_thread->event->time_stamp), NULL);
        }

        /* a_event->time_str is a cache, as strftime is slow.
         * It is modified when this event meets another time specifier, or time slips one second.
         * So it is a weak cache, just work when a event goes through only one time specifier.
         * If there is any better way, please tell me!
         */
        if (
             (a_thread->event->time_stamp.tv_sec != a_thread->event->time_last)
             || (a_spec->time_fmt != a_thread->event->time_fmt_last)
           ) {
                a_thread->event->time_last = a_thread->event->time_stamp.tv_sec;
                a_thread->event->time_fmt_last = a_spec->time_fmt;

                localtime_r(&(a_thread->event->time_stamp.tv_sec),
                            &(a_thread->event->time_local));

                a_thread->event->time_str_len = strftime(a_thread->event->time_str,
                        sizeof(a_thread->event->time_str),
                        a_spec->time_fmt, &(a_thread->event->time_local));
        }
        return zlog_buf_append(a_buf, a_thread->event->time_str, a_thread->event->time_str_len);
}

from zlog.

HardySimpson avatar HardySimpson commented on August 19, 2024

I improve it on 1.2.5,
NO time_fmt in zlog_event_t anymore,
where every time spec can have it's own strftime cache!

from zlog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.