Comments (3)
Yes, you are right. I fix it and launch zlog 1.2.2....
from zlog.
The last fix is not correct, simplely kick the cache will cause sometimes not fetch time. so I fix it again....
I think this fix will work, isn't it ?
static int zlog_spec_write_time(zlog_spec_t * a_spec, zlog_thread_t * a_thread, zlog_buf_t * a_buf)
{
if (!a_thread->event->time_stamp.tv_sec) {
gettimeofday(&(a_thread->event->time_stamp), NULL);
}
/* a_event->time_str is a cache, as strftime is slow.
* It is modified when this event meets another time specifier, or time slips one second.
* So it is a weak cache, just work when a event goes through only one time specifier.
* If there is any better way, please tell me!
*/
if (
(a_thread->event->time_stamp.tv_sec != a_thread->event->time_last)
|| (a_spec->time_fmt != a_thread->event->time_fmt_last)
) {
a_thread->event->time_last = a_thread->event->time_stamp.tv_sec;
a_thread->event->time_fmt_last = a_spec->time_fmt;
localtime_r(&(a_thread->event->time_stamp.tv_sec),
&(a_thread->event->time_local));
a_thread->event->time_str_len = strftime(a_thread->event->time_str,
sizeof(a_thread->event->time_str),
a_spec->time_fmt, &(a_thread->event->time_local));
}
return zlog_buf_append(a_buf, a_thread->event->time_str, a_thread->event->time_str_len);
}
from zlog.
I improve it on 1.2.5,
NO time_fmt in zlog_event_t anymore,
where every time spec can have it's own strftime cache!
from zlog.
Related Issues (20)
- 多进程写同一日志文件安全吗
- 配置规则没有生效 HOT 1
- 是否会加入异步写入文件的功能?
- zlog-1.2.16版本中转档失败问题
- 在1.2.12版本 获取锁仍然还是存在bug HOT 3
- 使用ZLOG进行日志打印的时候出现crash
- 使用最新版本1.2.13的日志文件转档功能,会出现文件锁死锁的现象。
- zlog加上轮转,在fork多进程情况下运行几千次还是会死锁 HOT 2
- zlog is blocked at the `write()` system call, causing the program to hang. HOT 2
- Severe Vulnerability in zlog 1.2.17 HOT 20
- zlog_rotater_trylock fail
- build failed for -Werror=pointer-to-int-cast
- Severe Vulnerability CVE-2024-22857 in zlog 1.2.16 HOT 2
- 内存泄露 HOT 2
- about zlog_rotater_trylock function doubt in version 1.2.17 HOT 2
- documentation: "%r" is not elucidated
- Compile error with clang HOT 1
- Suppress duplicate messages
- Rotate last week daily logs
- Failed to build on FreeBSD
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zlog.