Giter VIP home page Giter VIP logo

Comments (3)

tlehman avatar tlehman commented on August 23, 2024

Fixed in

func bindDeviceToVFIOPCIDriver(pd *v1beta1.PCIDevice) error {
vendorId := pd.Status.VendorId
deviceId := pd.Status.VendorId
var id string = fmt.Sprintf("%s %s", vendorId, deviceId)
file, err := os.OpenFile("/sys/bus/pci/drivers/vfio-pci/new_id", os.O_WRONLY, 0400)
if err != nil {
return err
}
_, err = file.WriteString(id)
if err != nil {
file.Close()
return err
}
file.Close()
return nil
}

from pcidevices.

w13915984028 avatar w13915984028 commented on August 23, 2024

Please double check unbindDeviceFromDriver

func unbindDeviceFromDriver(addr string, driver string) error {
	path := fmt.Sprintf("/sys/bus/pci/drivers/%s/unbind", driver)
	file, err := os.OpenFile(path, os.O_WRONLY, 0400)
..
	_, err = file.WriteString(addr)
	if err != nil {
                // file should be closed 
		return err   ////
	}
..
}

General practice in go is:

func unbindDeviceFromDriver(addr string, driver string) error {
...
	file, err := os.OpenFile(path, os.O_WRONLY, 0400)
..
       // after successfully OpenFile
       defer file.Close()   /// it will make sure, in any return path, file is closed

	_, err = file.WriteString(addr)

        // do NOT need any file.Close
...
..
}

from pcidevices.

tlehman avatar tlehman commented on August 23, 2024

Fixed in f10b170

from pcidevices.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.