duplicated bus stations at `stations list` about open-bus-map-search HOT 24 CLOSED

So from a very quick glance, this is not a real backend problem, but a problem with how we query the data.
If you take a look at the requests in the network tab, you'll see that we don't filter well on the dates, which results a duplication of rides, and therefore of stops:

• https://open-bus-stride-api.hasadna.org.il/gtfs_routes/list?limit=100&date_from=2023-10-18&date_to=2023-10-19&operator_refs=4&route_short_name=364 -> returns 6 results (2 routes of each line ref). The reason for that is that think the gtfs data is generated per day (in the MOT servers, as well as in the backend, because the planned routes can change)
• Therefore 2 rides are queried (1 for the 18.10, one for the 19.10), and this is why we get the stops duplication:

from open-bus-map-search.

@ArkadiK94 , looks great, I think you can close 🙏 😄

from open-bus-map-search.

filter out results with the same ID sounds like a good idea

from open-bus-map-search.

ok, I re-opened it for now, let's wait the response of @ShayAdler if there is required a change in the back-end as well

from open-bus-map-search.

It happens on many bus lines.
Though each entry presents you with different times and only the name is duplicated, I think it will be a good idea to merge those duplications to just one entry containing all the different times.

I believe it's worth doing on the backend, that will just return the data as we want it.
But if it's not possible you can assign the issue to me and I'll make a helper function to manipulate the data on the front end.

from open-bus-map-search.

totally agree that it better be done at backend...
may be it is worth to open issue there

from open-bus-map-search.

Okay, so let me know if I should work on it on the front or not 😄
Maybe I can take a look on the backend myself and see if I can make this modification there

@NoamGaash what do you think?

from open-bus-map-search.

from open-bus-map-search.

Okay, I'll take a look there and get back to you Sunday/Monday with my thoughts

from open-bus-map-search.

from open-bus-map-search.

AFAIK, there are subtle differences between both variations
@ShayAdler wdyt?

from open-bus-map-search.

So given the new info, what do we want to do about this issue?

from open-bus-map-search.

Awesome, I'll take a look over it ;)

from open-bus-map-search.

@NoamGaash is there a reason not to query only the actual date the user filtered on? This will solve the issue..
This bigger range selection sounds buggy for another reason - what if I searched for the 18.10, and this route does not exsit in this date, but is does exist on the 19.10? Currently, I'll see it in the search results

from open-bus-map-search.

you're right, it will be a better solution

from open-bus-map-search.

Perfect, so I have my task.
I'll go over the code and get to it.
Will update you soon

from open-bus-map-search.

so i took a deeper look on that issue, and it doesn't seem related to the dates.
i logged what i got back from the server and saw this:

they are all the same dates, only difference is the route key(look at the last two characters of the key of each duplications)
i can't really put my finger on why we get those duplications. will you be able to take a quick look?
here is the example of the data i tried to query on the frontend:

waiting on your response <3 @NoamGaash @ShayAdler Thanks!

from open-bus-map-search.

@NoamGaash I close this issue, the discussion about this issue continues in issue #176

from open-bus-map-search.

Hi, @ArkadiK94 you sure this is the same problem? My issue is trying to better handle a by-design case, while this is an actual bug.

from open-bus-map-search.

Yeah, @Pafestivo wrote that the difference between the routes is only the key one with # while the other with number. Which indicates that there are two routes with the same "from destination" and "to destination". Maybe, I am wrong tell me if so , and I will reopen this issue.

from open-bus-map-search.

I am sorry, the issue talks about two different routes where here the bug is about duplicated stops. As a result, I am not sure if it is the same issue so I will reopen it for now. @ShayAdler @AdlerShay

from open-bus-map-search.

@ArkadiK94 yep this is definitly confusing 😅 , but I still think this is not the same issue. The diff is that in #176 , the line_ref is different (in gtfs, each direction of the line gets a different line_ref, so for exmaple the same line 37 from Tel Aviv to Yehud does not have the same line ref as from Yehud to Tel Aviv, the same goes for "halufot").

Here are you can see, it is the same (as well as the route_long_name and route_mkt, but the dates are different.
I have not deeply investigated the pattern with the "#", but I guess that this line can sometimes have other halufot.
Let me know if it is still unclear :)

from open-bus-map-search.

@ShayAdler @NoamGaash Do you want this issue to be still open to make the relevant changes in the backend? Or is the filter in frontend is enough?

from open-bus-map-search.

@ArkadiK94
I'm not sure, feel free to re-open

from open-bus-map-search.