timeline graph at the dashboard (אחוזי יציאה מסך הנסיעות לפי זמן) should be reversed about open-bus-map-search HOT 10 CLOSED

@NoamGaash @shootermv I close this issue because the related pr was merged

from open-bus-map-search.

@NoamGaash
Yes, intuitively you see time (values in general) increasing as it goes to the right, like mathematical plots (XY).

But also depends on requirements if they say otherwise.

from open-bus-map-search.

@VSciFlight - It looks like the issue is the inherited direction of the application.

According to the investigation - it is the "Recharts" library that is used to draw these charts (correct me if I was mistaken).

This one can be fixed by applying a reversed={true} prop to the <XAxis> component.

The fix can be applied here

After applying the mentioned prop - a charts graph looks like the following:

Also, there is another question here. Should we also change the location of the YAxis? To be in the opposite orientation like this?

@NoamGaash
Please assign this one to me. What I mentioned should fix this issue. Or maybe there is another solution that you can think about and I'll be happy to execute.

from open-bus-map-search.

@NoamGaash
What about this one?
Can I start to work on it?

from open-bus-map-search.

@AlexKomanov
sure! thanks

from open-bus-map-search.

@AlexKomanov @shootermv
just one question - are we sure that the X axis shouldn't be RTL, since the application is in Hebrew?

from open-bus-map-search.

@VSciFlight you're right
https://www.facebook.com/groups/uximembers/posts/7669185879775101/?__cft__[0]=AZX0TZWwo9Jhc_b7j9W2oHLnCQMrMg84HiilA3M4WJI1y3wqJtXgkkh-1yw3VMToeiHiTk8WFt79RSQX4v7V3gRvfOPhyjhl1cTulAN3tKPYy5oxmr8lJPBD3YpxfTQxIRRc-xqZq_Jfjg72VwayHE3K5ATd7fEXhtX-ldz3EHWxFQ&__tn__=%2CO%2CP-R
thanks!

from open-bus-map-search.

@NoamGaash
I am not a part of the group from where you shared a link. Can you please share here a screenshot?

Also, what is our action item here? To reverse the XAxis to be like the following?

cc: @VSciFlight

from open-bus-map-search.

@AlexKomanov
Yeah, I needed to mention that

from open-bus-map-search.

from open-bus-map-search.