DashboardPage - "operators" filter should be moved into "5 worst companies" area about open-bus-map-search HOT 19 CLOSED

As for the 5 enteries limit, I would say that it is a bit disorianting considering you have a full list of them on the right side.
I would suggest changing the dropdown to a search field, all while keeping the 5 items limit but make it contextual.

from open-bus-map-search.

While I'm at that, I would suggest to change the text in the Operator widget, when a company is selected it doesn't represent the 5 worst.
My suggestion is either to change the text from "5 worst" to something like "Worst operators" or to add another line and switch between them when an operator is selected

from open-bus-map-search.

@i5x64BIT Hi, Is this issue still in progress? On one hand, the pr was merged, on the other hand, the title is still "5 worst..."

Ohh yeah, I'll change it tomorrow

from open-bus-map-search.

@i5x64BIT @NoamGaash @shootermv The relevant pr was merged so I close this issue. @i5x64BIT Great work 👏

from open-bus-map-search.

I think the idea behind limiting the operators list to 5 entries ment to reduce noise. most viewers won't really care about operators like "אודליה מוניות בעמ". I have no clue why MOT provides GTFS and SIRI data about them in the first place.. I should ask the product/backend guys as they are way more expert than myself.

regarding making the filters change all the views, and making the operator names clickable - I believe it's a great idea.

from open-bus-map-search.

@NoamGaash I can work on the clickable operators, perhaps we should open a separate issue for it.
As for that filter thing I didn't really get it, if you could explain more about it I could probably takle it too.

from open-bus-map-search.

the idea is once you choose operator in the חברה מפעילה then in my opinion it should probably affect all three views for example if you choose אגד the מפעילי תח"צ לפי קיום נסיעות מתוכננות should change to עמידה בנסיעות מתוכננות עבור ״אגד״
and show only אגד

if you decide to enable multi select, then some generic titles should be provided so it won't be too long

from open-bus-map-search.

regarding the click, I think you can support multi click up to 5 operators that will be alighted with the search that will give the option to choose in the drop down a few operators
and also clicking on chosen operator should un-choose it

from open-bus-map-search.

those are good ideas

from open-bus-map-search.

@i5x64BIT
Hi, are you still on this issue?

from open-bus-map-search.

@NoamGaash Yes, I took some time off :)

from open-bus-map-search.

Hey @NoamGaash @i5x64BIT
@shootermv told me the filter should be related only to the worst companies view.
So need just adjust the place of the filter to be part of this view for better UX

from open-bus-map-search.

@Nastia1409 I believe it could also filter the view on the bottom, but it's up for you to make the decision.

from open-bus-map-search.

from open-bus-map-search.

@NoamGaash @shootermv it seems as if there is no clear image on the resolution of this issue, I would suggest to get the dessicions straight and start working afterwards.
@NoamGaash I could move to another issue until then if needed.

from open-bus-map-search.

@i5x64BIT there are two solutions, both valid. Feel free to implement any of them

from open-bus-map-search.

First approach - make the dropdown applied to all charts
Second solution - move it into one of the relevant tile

Both options are equally good in my opinion.

from open-bus-map-search.

from open-bus-map-search.

@i5x64BIT Hi, Is this issue still in progress? On one hand, the pr was merged, on the other hand, the title is still "5 worst..."

from open-bus-map-search.