Giter VIP home page Giter VIP logo

Comments (7)

Haswell-s avatar Haswell-s commented on June 19, 2024 2

I can take it

from open-bus-map-search.

giladfuchs avatar giladfuchs commented on June 19, 2024

since this map is relevant only for isreal.

i think more correct it's to do this on server side.

from open-bus-map-search.

NoamGaash avatar NoamGaash commented on June 19, 2024

@giladfuchs The server side should NOT format the date.
The backend should return standard timestamp (ISO formatted, or epoch timestamp), and the frontend should format it.

from open-bus-map-search.

NoamGaash avatar NoamGaash commented on June 19, 2024

@giladfuchs in react we store the dates inside date / moment.js objects. therefore, making the backend change formats is meaningless. we ignore the backend formatting.

from open-bus-map-search.

NoamGaash avatar NoamGaash commented on June 19, 2024

@i5x64BIT Hi, how is it going? Do you have any question? Let us know if any help is needed

from open-bus-map-search.

Haswell-s avatar Haswell-s commented on June 19, 2024
Screen.Recording.2024-01-14.at.8.43.51-2.mov

Done, does it look good?
Plus a few suggestion:

  1. On the by-date there is duplicate information so either remove the indexes from x axis or remove the date from the display.
  2. The by-hour graph is very confusing when it contains a few days, a simple solution would be to make a divider for each day and add a date index for each one, or give every second day a darker background.

Do I need to make a different pull request for the extra stuff?

from open-bus-map-search.

NoamGaash avatar NoamGaash commented on June 19, 2024

@i5x64BIT making separated pull request is recommended
https://blog.codacy.com/small-pull-requests

from open-bus-map-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.