Comments (7)
I can take it
from open-bus-map-search.
since this map is relevant only for isreal.
i think more correct it's to do this on server side.
from open-bus-map-search.
@giladfuchs The server side should NOT format the date.
The backend should return standard timestamp (ISO formatted, or epoch timestamp), and the frontend should format it.
from open-bus-map-search.
@giladfuchs in react we store the dates inside date / moment.js objects. therefore, making the backend change formats is meaningless. we ignore the backend formatting.
from open-bus-map-search.
@i5x64BIT Hi, how is it going? Do you have any question? Let us know if any help is needed
from open-bus-map-search.
Screen.Recording.2024-01-14.at.8.43.51-2.mov
Done, does it look good?
Plus a few suggestion:
- On the by-date there is duplicate information so either remove the indexes from x axis or remove the date from the display.
- The by-hour graph is very confusing when it contains a few days, a simple solution would be to make a divider for each day and add a date index for each one, or give every second day a darker background.
Do I need to make a different pull request for the extra stuff?
from open-bus-map-search.
@i5x64BIT making separated pull request is recommended
https://blog.codacy.com/small-pull-requests
from open-bus-map-search.
Related Issues (20)
- Proposal: Simplify Domain Name for Better UX HOT 3
- style | public-appeal page touch-ups HOT 2
- Feature | Add complaint button to bus tooltip HOT 2
- Test | header-links icons should be unique HOT 2
- Allow better zoom level HOT 5
- test | add a visual test to the home page
- דרך אגד HOT 2
- new agencies should appear in the dashboard HOT 9
- home page anchor links overflows on hover, home page links cropped on mobile HOT 2
- בעיה במצב כהה HOT 3
- בעיה בטופס דיווח באגים HOT 8
- history tab says "line not found" when I finish selecting all fields HOT 3
- Pattern tab - shows wrong data HOT 4
- User wants to view "patterns of missed trips" HOT 4
- The "donations" tab in sidebar needs to open a pop up. Same as the icon in header
- ci: deploy a preview of the test report after every PR update HOT 3
- test: add visual tests for dark mode
- Apply code review comments HOT 2
- fix: DateSelector selector validation message issues
- changing the date in the gaps page doesn't refresh all of the data
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-bus-map-search.