Giter VIP home page Giter VIP logo

Comments (5)

NoamGaash avatar NoamGaash commented on July 19, 2024

sounds great!
moving it to utils file/folder will make sense

from open-bus-map-search.

guyStrauss avatar guyStrauss commented on July 19, 2024

Hey guys!
I moved the function to another file under utils just like @rzarviv suggested and renamed it to busIcon as it made more sense.
I don't have permission to push the branch, can you help me?

from open-bus-map-search.

rzarviv avatar rzarviv commented on July 19, 2024

Hi @keshet1, in order to contribute to this repo, you need to follow these steps:

  1. Fork this repo.
  2. Create a branch in your fork and make your changes in it.
  3. Create a Pull Request and assign one (or more) of the project maintainers to review your code.

If you encounter any problem with any of those steps, please comment here and we'll try to help.

from open-bus-map-search.

guyStrauss avatar guyStrauss commented on July 19, 2024

Hi @keshet1, in order to contribute to this repo, you need to follow these steps:

  1. Fork this repo.
  2. Create a branch in your fork and make your changes in it.
  3. Create a Pull Request and assign one (or more) of the project maintainers to review your code.

If you encounter any problem with any of those steps, please comment here and we'll try to help.

Did these, but it seems I cannot assign anyone for reviewing

from open-bus-map-search.

rzarviv avatar rzarviv commented on July 19, 2024

I don't know why you weren't able to ask for a review (maybe it's a permission issue), but I assigned @NoamGaash and myself to review your changes.

Thanks for your contribution, @guyStrauss!

from open-bus-map-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.