Get rid of CRA about open-bus-map-search HOT 12 CLOSED

I can work on this.

from open-bus-map-search.

I was calculating the impact of this contribution.

With CRA:
Development Server Start-Up Time - 28 to 30 seconds!

With Vite:
Development Server Start-Up Time - 789 milliseconds!

MASSIVE IMPROVEMENT!

from open-bus-map-search.

I am following the instructions in the article that you sent.

As per Step 8 we will have to migrate our testing library from Jest to Vitest. Currently, all our tests have been written in Jest. Therefore, migrating to Vitest will break the project.

I am making some changes to the package.json file but I am not sure what to write for test and eject as they both used react-scripts earlier.

"scripts": {
    "start": "vite",
    "build": "tsc && vite build",
    "serve": "vite preview",
    "test": "",
    "test:playwright": "playwright test",
    "eject": "",
    "lint": "eslint . --max-warnings 0",
    "lint:fix": "eslint . --fix",
    "format": "prettier --write './**/*.{js,jsx,ts,tsx,css,md,json}' --config ./.prettierrc"
  },

Thoughts?

from open-bus-map-search.

@NoamGaash No we have Playwright tests.

from open-bus-map-search.

thank you @knightcube !
you solved a real tech debt in our project. it's super helpful and appreciated
🙏 ⭐ 🥇

from open-bus-map-search.

If you don't need any Server-Side Rendering abilities then Vite is probably the best alternative for create-react-app AFAIK.

from open-bus-map-search.

@knightcube thanks! let me know if you have any question, or if there's any help required

from open-bus-map-search.

are you sure that we have Jest tests?

from open-bus-map-search.

@knightcube Playwright won't care about the way we transpile our project. It just uses yarn start and looks for the 8080 port

from open-bus-map-search.

But why is the playwright test not running here? - https://github.com/hasadna/open-bus-map-search/actions/runs/6378722977/job/17313602705?pr=86

from open-bus-map-search.

Did you try to run it locally? Maybe its listening to the wrong port number

from open-bus-map-search.

Yeah I updated the port numbers in #86 just now.

from open-bus-map-search.