SearchContext creating a Provider for this context about open-bus-map-search HOT 6 OPEN

I also agree with refactoring.
Do we need to save the data in SessionStorage?
or we can remove the Context completely and use the SearchParams hook in components?

replace

  const { operatorId, lineNumber, timestamp, routes, routeKey } = search```

with

const  [operatorId,setOperatorId] = useSearchParams('')
const  [lineNumber,setLineNumber] = useSearchParams('')
const  [routes,setRoutes] = useSearchParams('')
const  [routeKey,setRouteKey ] = useSearchParams('')
const  [timestamp,setTimestamp] = useSearchParams(moment().valueOf())

from open-bus-map-search.

@ArkadiK94 @aviv1620
I support both suggestions.
Having the search parameters stored in the local storage will allow us to retrieve the latest search for the user. It's very likely that our users will want to search the same line over and over.
However, it complicates things, and I prefer simplicity when maintaining such a project.

Feel free to make it comfortable - your help is very appreciated

from open-bus-map-search.

I think we need merge this issue with issue #83 and issue #71.
The problems come from the same place on the code.

from open-bus-map-search.

what do you think about redux?

from open-bus-map-search.

@giladfuchs
We store the data on URL params.
So I think that the useSearchParams have some logic that similar to state management.

from open-bus-map-search.

@giladfuchs overcomplicated for our needs.
IMO, using react context will be better fit for our needs.

from open-bus-map-search.