Proposal to Integrate SIEVE Eviction Algorithm about golang-lru HOT 11 OPEN

Awesome! Let us know if you need any help or have any question. :)

from golang-lru.

@venkatsvpr Great to hear from you! Thanks for your support.

Btw, I think it might be better to integrate SIEVE in an opt-in manner.

from golang-lru.

I have been using golang-lru repo for many years now. Thanks everyone who contributed.

I read the Sieve paper and it is super cool. I would like to volunteer to integrate sieve into golang-lru.

Thanks!

cc - @yazhuo

from golang-lru.

Thanks @1a1a11a @yazhuo

Yes - Agree!

from golang-lru.

Hi folks, @irenarindos @mgaffney @paskal

Want to touch base with you to see if the proposal make sense to you.

Thanks!

from golang-lru.

Hi!

We are interested in seeing a more detailed proposal. Keep in mind that any proposed changes should not change the default behavior or characteristics of the current v2 implementation (meaning using SIEVE would have to be optional). We could then gather feedback from users and consider making it the default in the next revision (v3).

from golang-lru.

Hi @mgaffney Thanks for getting back.

I have added two New methods (NewSieve and NewSieveWithEvict) which would work with SIEVE evicition.

Please take a look at this PR and add your comments.

from golang-lru.

@venkatsvpr that PR is not for this repo

from golang-lru.

Yes. Let me complete the PR and send out another PR for this repo. Thanks!

from golang-lru.

I've updated the PR #169

Please take a look.mgaffney

Also, if & when there is a v3 version, It'd be great with the change the New signature. This would make us future proof the new changes we might have. (like sieve)

from golang-lru.

@mgaffney Did you get a chance to check out the PR #169
Let me know if I can be of any help.

Thanks!

from golang-lru.