Giter VIP home page Giter VIP logo

Comments (3)

DanStough avatar DanStough commented on July 28, 2024 1

Thanks for the detailed summary and #118 , @boydjeff! I propose the following:

  1. Close #118
  2. Make a new PR in the same spirit as your option 2 above:
  3. If one of the multicast/unicast interfaces for ipv6 is nil, set the other to nil, log, and adjust c.use_ipv6.
  4. If one of the multicast/unicast interfaces for ipv4 is nil, set the other to nil, log, and adjust c.use_ipv4.
  5. If both c.use_ipv4 and c.use_ipv6 are false, error out.
  6. Close #87 and #43 when it all gets merged.

Let me know what you think or if you'd like to make a new PR. Otherwise I can make a PR in-between things.

from mdns.

boydjeff avatar boydjeff commented on July 28, 2024

I'm happy to do as you propose.

from mdns.

DanStough avatar DanStough commented on July 28, 2024

Closed by #120

from mdns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.