Giter VIP home page Giter VIP logo

Comments (10)

hans-d avatar hans-d commented on July 17, 2024 1

saw some recent changes (not yet in a release) to this part of the code, so lets see what that results in.

from terraform-provider-aws.

github-actions avatar github-actions commented on July 17, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

from terraform-provider-aws.

justinretzolk avatar justinretzolk commented on July 17, 2024

Hey @hans-d 👋 Thank you for taking the time to raise this! Are you able to supply a sample configuration in case whoever picks this up needs that information?

from terraform-provider-aws.

justinretzolk avatar justinretzolk commented on July 17, 2024

@hans-d the new release should be out in an hour or so, so hopefully that takes care of it 👍

from terraform-provider-aws.

hans-d avatar hans-d commented on July 17, 2024

Still an issue with 5.56

│ The plugin.(*GRPCProvider).ApplyResourceChange request was cancelled.
╵
Releasing state lock. This may take a few moments...

Stack trace from the terraform-provider-aws_v5.56.0_x5 plugin:

panic: runtime error: index out of range [0] with length 0

goroutine 341 [running]:
github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp.resourceUserPoolUpdate({0x1416e428, 0x40046df650}, 0x40049b1200, {0x120ff600, 0x4003c11040})
	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp/user_pool.go:1000 +0x2144
github.com/hashicorp/terraform-provider-aws/internal/provider.New.(*wrappedResource).Update.interceptedHandler[...].func10(0x40049b1200?, {0x120ff600?, 0x4003c11040})
	github.com/hashicorp/terraform-provider-aws/internal/provider/intercept.go:113 +0x1d8
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).update(0x1416e428?, {0x1416e428?, 0x40042d7440?}, 0xd?, {0x120ff600?, 0x4003c11040?})
	github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:835 +0x64
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0x400120b420, {0x1416e428, 0x40042d7440}, 0x40042e6ea0, 0x40049b0b80, {0x120ff600, 0x4003c11040})
	github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:947 +0x670
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0x4003bfe300, {0x1416e428?, 0x40042d7380?}, 0x4001e379f0)
	github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/grpc_provider.go:1153 +0xaa4
github.com/hashicorp/terraform-plugin-mux/tf5muxserver.(*muxServer).ApplyResourceChange(0x4001aee5b0, {0x1416e428?, 0x40042d70b0?}, 0x4001e379f0)
	github.com/hashicorp/[email protected]/tf5muxserver/mux_server_ApplyResourceChange.go:36 +0x184
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0x400102e320, {0x1416e428?, 0x40042d66f0?}, 0x4000ca0a80)
	github.com/hashicorp/[email protected]/tfprotov5/tf5server/server.go:865 +0x2b4
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x11ec6d80, 0x400102e320}, {0x1416e428, 0x40042d66f0}, 0x4000c38d80, 0x0)
	github.com/hashicorp/[email protected]/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:518 +0x1c0
google.golang.org/grpc.(*Server).processUnaryRPC(0x40012d0200, {0x1416e428, 0x40042d6660}, {0x141c4b20, 0x400051e180}, 0x40042d17a0, 0x4002087ce0, 0x1d5c0998, 0x0)
	google.golang.org/[email protected]/server.go:1369 +0xb58
google.golang.org/grpc.(*Server).handleStream(0x40012d0200, {0x141c4b20, 0x400051e180}, 0x40042d17a0)
	google.golang.org/[email protected]/server.go:1780 +0xb20
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/[email protected]/server.go:1019 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 59
	google.golang.org/[email protected]/server.go:1030 +0x13c

Occurs when having no lambda config before, and adding one with a subsequent apply run

from terraform-provider-aws.

hans-d avatar hans-d commented on July 17, 2024

if v, ok := d.GetOk("lambda_config"); ok {
if v, ok := v.([]interface{})[0].(map[string]interface{}); ok && v != nil {
if d.HasChange("lambda_config.0.pre_token_generation") {
v["pre_token_generation_config"].([]interface{})[0].(map[string]interface{})["lambda_arn"] = d.Get("lambda_config.0.pre_token_generation")
}
if d.HasChange("lambda_config.0.pre_token_generation_config.0.lambda_arn") {
v["pre_token_generation"] = d.Get("lambda_config.0.pre_token_generation_config.0.lambda_arn")
}
input.LambdaConfig = expandLambdaConfigType(v)
}
}

So very specific re change in pre-generation

lambda_config {
          pre_token_generation = "arn:aws:lambda:eu-west-1:123456789012:layer:blah-pre-token"
        }

from terraform-provider-aws.

ewbankkit avatar ewbankkit commented on July 17, 2024

@hans-d Thanks for following up with this -- we'll fix for a likely patch release today addressing a couple of regressions.

from terraform-provider-aws.

ewbankkit avatar ewbankkit commented on July 17, 2024

I can reproduce with a new acceptance test case:

% make testacc TESTARGS='-run=TestAccCognitoIDPUserPool_addLambda' PKG=cognitoidp ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cognitoidp/... -v -count 1 -parallel 3  -run=TestAccCognitoIDPUserPool_addLambda -timeout 360m
=== RUN   TestAccCognitoIDPUserPool_addLambda
=== PAUSE TestAccCognitoIDPUserPool_addLambda
=== CONT  TestAccCognitoIDPUserPool_addLambda
panic: runtime error: index out of range [0] with length 0

goroutine 3642 [running]:
github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp.resourceUserPoolUpdate({0x1186146b0, 0x14009865140}, 0x14009797b80, {0x118385700, 0x14009f880d0})
	/Users/kewbank/src/github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp/user_pool.go:1000 +0x2144
github.com/hashicorp/terraform-provider-aws/internal/provider.New.(*wrappedResource).Update.interceptedHandler[...].func10(0x14009797b80?, {0x118385700?, 0x14009f880d0})
	/Users/kewbank/src/github.com/hashicorp/terraform-provider-aws/internal/provider/intercept.go:113 +0x1d8
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).update(0x1186146b0?, {0x1186146b0?, 0x140098a4660?}, 0xd?, {0x118385700?, 0x14009f880d0?})
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:835 +0x64
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0x140024242a0, {0x1186146b0, 0x140098a4660}, 0x14009617930, 0x1400973d980, {0x118385700, 0x14009f880d0})
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:947 +0x670
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0x14005e138a8, {0x1186146b0?, 0x140098a45d0?}, 0x14003f99db0)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/grpc_provider.go:1153 +0xaa4
github.com/hashicorp/terraform-plugin-mux/tf5muxserver.(*muxServer).ApplyResourceChange(0x14000322a10, {0x1186146b0?, 0x140098a4330?}, 0x14003f99db0)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/[email protected]/tf5muxserver/mux_server_ApplyResourceChange.go:36 +0x184
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0x14006d9e8c0, {0x1186146b0?, 0x1400977faa0?}, 0x14009759110)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/tf5server/server.go:865 +0x2b4
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x118165aa0, 0x14006d9e8c0}, {0x1186146b0, 0x1400977faa0}, 0x1400973d280, 0x0)
	/Users/kewbank/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:518 +0x1c0
google.golang.org/grpc.(*Server).processUnaryRPC(0x14004e9f000, {0x1186146b0, 0x1400977fa10}, {0x11866a8e0, 0x1400822c180}, 0x140098917a0, 0x14009f6fc20, 0x121b0b8d8, 0x0)
	/Users/kewbank/go/pkg/mod/google.golang.org/[email protected]/server.go:1369 +0xb58
google.golang.org/grpc.(*Server).handleStream(0x14004e9f000, {0x11866a8e0, 0x1400822c180}, 0x140098917a0)
	/Users/kewbank/go/pkg/mod/google.golang.org/[email protected]/server.go:1780 +0xb20
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	/Users/kewbank/go/pkg/mod/google.golang.org/[email protected]/server.go:1019 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 1351
	/Users/kewbank/go/pkg/mod/google.golang.org/[email protected]/server.go:1030 +0x13c
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	30.141s
FAIL
make: *** [testacc] Error 1

from terraform-provider-aws.

github-actions avatar github-actions commented on July 17, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

from terraform-provider-aws.

github-actions avatar github-actions commented on July 17, 2024

This functionality has been released in v5.56.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

from terraform-provider-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.