Race condition in several tests (order dependent) about terraform HOT 4 CLOSED

Sorry what makes there a race condition here? As far as I know there isn't any parallelism happening in the places you linked. Am I missing something?

from terraform.

Er, race in that it depends on a sequence that is not always ordered in the same way each time. (not exactly a race, but I don't know if there is a proper term for it). Basically, these tests assume that map key/value pairs will remain in the same order when iterated over, which is not the case in Go. It's an intentional language design choice to prevent using maps as ordered sets.

The tests therefore fail sometimes and not others because the small sample size lends to a higher probability that they will be in the same order, but they won't always be, hence why my first instinct was to call it a "race" though really I guess it is an "inconsistent iteration" error.

from terraform.

There's a simple fix for merge and append tests at #61, but WriteDot is a little trickier.

from terraform.

I found a solution for TestWriteDot and it is also in #61 now.

from terraform.