new-api: Don't throw errors if SDL_GetError is the empty string about sdl2 HOT 2 CLOSED

You may still wish to throw an error when the return value of a function indicates that an error has occurred -- it shouldn't happen but it's better to do so than not, as something has probably gone wrong either way.

from sdl2.

We can not blindly ignore the return values from SDL, even if SDL_GetError indicates that nothing has gone wrong, at least not uniformly.

Take for example functions that return CStrings. If it were to happen that we got a nullPtr as a return value and SDL_GetError indicated that nothing has gone wrong, we definitely do not want to proceed to use that string.

With that aside, there may lie shenanigans or bugs in SDL in which we are forced to check with SDL_GetError to really know if there was an error, but that has to be done on a case-by-case basis.

from sdl2.