Giter VIP home page Giter VIP logo

Comments (9)

addons-assistant avatar addons-assistant commented on June 9, 2024

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

from addon-grocy.

jackwilsdon avatar jackwilsdon commented on June 9, 2024

See #38 and #47 - it looks like this may be a problem with Ingress. Have you tried exposing Grocy on its own port and seeing if the same issue occurs?

from addon-grocy.

snipes040 avatar snipes040 commented on June 9, 2024

Hmm ok I haven't tried that yet as my system is on docker behind my traefik reverse proxy so I'll need to figure out how to expose the addon via SSL. Thanks for the links to the #38 issue. What's also strange is that I was able to upload 3 PDF's without any problem. Is this in the works of being fixed do you know?

from addon-grocy.

jackwilsdon avatar jackwilsdon commented on June 9, 2024

I've not found any mention of this being in the works. Seems like this issue could be in Home Assistant itself - will need more testing to confirm it (I might get round to this at some point, but it'd be great if someone else could do some testing).

https://github.com/home-assistant/home-assistant/blob/00dc7216093abd099b1e4a58a14876cc9ed2896e/homeassistant/components/hassio/ingress.py#L123

Looks like the aiohttp client Home Assistant is using to forward requests to the right ingress container has a default max request size of 1024^2, which happens to be 1048576.

GitHub
🏡 Open source home automation that puts local control and privacy first - home-assistant/home-assistant

from addon-grocy.

cerebrate avatar cerebrate commented on June 9, 2024

Yeah, this is an ingress problem. (Just reported it here: home-assistant/supervisor#1420 before finding this.) As a workaround, you can upload just fine to grocy by accessing on its port 9192.

That said, it's not a complete fix. While I was poking around the containers looking for the issue, I found that despite the last two lines in https://github.com/hassio-addons/addon-grocy/blob/master/grocy/rootfs/etc/php7/conf.d/99-grocy.ini , the post_max_size and upload_max_filesize weren't being set to 64M by PHP (checked by running phpinfo() in a test file). I had to amend those lines to just

post_max_size = 64M
upload_max_filesize = 64M

to get it to work.

GitHub
Grocy - Community Hass.io Add-on for Home Assistant - hassio-addons/addon-grocy

from addon-grocy.

cerebrate avatar cerebrate commented on June 9, 2024

Fix inbound:

from addon-grocy.

frenck avatar frenck commented on June 9, 2024

Yep!

from addon-grocy.

frenck avatar frenck commented on June 9, 2024

Fix has been applied to the Home Assistant Supervisor.

from addon-grocy.

addons-assistant avatar addons-assistant commented on June 9, 2024

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

from addon-grocy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.