Giter VIP home page Giter VIP logo

Comments (5)

jsierles avatar jsierles commented on May 21, 2024 1

Would this also allow something like using a secret as a Docker build argument? For example, now I need to pass a Github token to a Dockerfile for fetching Github repos during the build. I can get the secret into Gitkubed's environment, but I see there is no way to pass a build argument currently.

from gitkube.

tirumaraiselvan avatar tirumaraiselvan commented on May 21, 2024 1

Yes, this issue is to make available arbitrary params to the build environment which can then be used in custom hooks. Custom hooks is in a WIP branch although I haven't gotten around to parameterization part yet. For now, the easiest way is to keep the token in the Dockerfile. The harder way is to fork from master and build your own version of Gitkube.

from gitkube.

coco98 avatar coco98 commented on May 21, 2024

@jsierles Yep. You can then load the build argument from the kubernetes environment

kubectl get secrets my-secrets -o json | jq -r '.data."githubToken"' | base64 --decode

and then pass that as a build-arg to the docker build command.

@tirumaraiselvan Does that make sense?

from gitkube.

jsierles avatar jsierles commented on May 21, 2024

Yeah sounds good. But this is still not done or on any WIP branch, correct? Is there an easy way to manually update the hook besides updating gitkube to support more docker build arguments and redeploying it?

from gitkube.

tirumaraiselvan avatar tirumaraiselvan commented on May 21, 2024

@jsierles docker build args support is here #64

from gitkube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.