Giter VIP home page Giter VIP logo

Comments (4)

kellabyte avatar kellabyte commented on July 24, 2024

Currently Haywire automatically free's the http_request here https://github.com/kellabyte/Haywire/blob/master/src/haywire/http_request.c#L285. It assumes that calling the users callback will be synchronous. I think we should move this to here https://github.com/kellabyte/Haywire/blob/master/src/haywire/http_server.c#L293 so that the user can spawn a thread. This would facilitate zero-copy as well.

from haywire.

kellabyte avatar kellabyte commented on July 24, 2024

Haywire already has a send_response_complete() callback. See the hello world sample.

void response_complete(void* user_data)
{
    // Here we would could free http_request and hw_http_response.
    // Should make names consistent.
}

void get_root(http_request* request, hw_http_response* response, void* user_data)
{
    // ... Do a bunch of stuff...

    // This could also free http_request.
    hw_http_response_send(response, "user_data", response_complete);
}

from haywire.

kellabyte avatar kellabyte commented on July 24, 2024

I think the current haywire free's buffers at the wrong spot. It free's them after parsing/calling the callback when it should do it after the response is sent.

from haywire.

nmdguerreiro avatar nmdguerreiro commented on July 24, 2024

Fixed by #103

from haywire.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.