It seems like there is a bug when there is an interface property involved -- when ther

I just wasn’t sure I could apply it as globally as you did </blockquo

Bug: Cannot Decompile IQueryable<T> after using constrained generic when TInterface has multiple implementations about delegatedecompiler HOT 5 CLOSED

cmeyertons commented on June 2, 2024

Bug: Cannot Decompile IQueryable after using constrained generic when TInterface has multiple implementations

from delegatedecompiler.

Comments (5)

hazzik commented on June 2, 2024

That is interesting. There is a similar test to one you've submitted:

DelegateDecompiler/src/DelegateDecompiler.EntityFramework.Tests/TestGroup50Types/Test01Strings.cs

Lines 73 to 93 in bf1fffc

 public void TestGenericMethodPersonHandle() 

 { 

 using (var env = new MethodEnvironment(classEnv)) 

 { 

 //SETUP 

 var linq = env.Db.EfPersons.Select(x => x.FirstName + (x.MiddleName == null ? "" : " ") + x.MiddleName + " " + x.LastName).ToList(); 

 //ATTEMPT 

 env.AboutToUseDelegateDecompiler(); 

 var dd = GetGenericPersonHandle(env.Db.EfPersons).Decompile().ToList(); 

 //VERIFY 

 env.CompareAndLogList(linq, dd); 

 } 

 } 

 public IQueryable<string> GetGenericPersonHandle<T>(IQueryable<T> people) 

 where T : class, EfItems.Abstracts.IPerson 

 { 

 return people.Select(x => x.FullNameHandleNull); 

 }

Only difference is in where T definition. One we have with class, the submitted is without class. Adding class to your test fixes it. And removing breaks our test.

from delegatedecompiler.

cmeyertons commented on June 2, 2024

The class constraint fixing it is quite bizarre! Your solution is more elegant than mine - I just wasn’t sure I could apply it as globally as you did and tried to leverage the knowledge of the caller.

Looks great to me. What is the turnaround time on getting a fix published? On Monday, we will test adding the class constraint as a workaround.

from delegatedecompiler.

hazzik commented on June 2, 2024

What is the turnaround time on getting a fix published?

I was going to review one other PR, and then wanted to publish a new version. It is already past my deadline as I was going to do that on the past weekend (it's Monday here already).

from delegatedecompiler.

hazzik commented on June 2, 2024

I just wasn’t sure I could apply it as globally as you did

When there is an upcasting (cast to a parent type) - it should be safe to remove. I was worried about explicit interfaces, but tested them locally - works as expected.

from delegatedecompiler.

cmeyertons commented on June 2, 2024

Sounds great! Thank you very much for the quick resolution on this one!

from delegatedecompiler.

Recommend Projects

Bug: Cannot Decompile IQueryable<T> after using constrained generic when TInterface has multiple implementations about delegatedecompiler HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public void TestGenericMethodPersonHandle()
	{
	using (var env = new MethodEnvironment(classEnv))
	{
	//SETUP
	var linq = env.Db.EfPersons.Select(x => x.FirstName + (x.MiddleName == null ? "" : " ") + x.MiddleName + " " + x.LastName).ToList();

	//ATTEMPT
	env.AboutToUseDelegateDecompiler();
	var dd = GetGenericPersonHandle(env.Db.EfPersons).Decompile().ToList();

	//VERIFY
	env.CompareAndLogList(linq, dd);
	}
	}

	public IQueryable<string> GetGenericPersonHandle<T>(IQueryable<T> people)
	where T : class, EfItems.Abstracts.IPerson
	{
	return people.Select(x => x.FullNameHandleNull);
	}