Giter VIP home page Giter VIP logo

Comments (5)

rimmartin avatar rimmartin commented on July 22, 2024

node::Buffer::HasInstance is returning true for a Float64Array with hdf5 v1.10.0-patch1; causing grief for io with typed arrays.

from hdf5.node.

rimmartin avatar rimmartin commented on July 22, 2024

node::Buffer is now ArrayBufferView https://v8docs.nodesource.com/node-8.0/da/d3d/classv8_1_1_array_buffer_view.html
nodejs/node@faa447b

Adjusting for this; there may be advantages with it

from hdf5.node.

rimmartin avatar rimmartin commented on July 22, 2024

Hi @vincent-tr,

When you go to nodejs v8.4.0 I believe we can collapse the readDataset and readDatasetAsBuffer to one interface readDataset. The definition of what a Buffer is changed to include all typed arrays and dataview.

Might need to branch for older versions and simplify this for v8.4.0 on

from hdf5.node.

rimmartin avatar rimmartin commented on July 22, 2024

from javascript to c++ nodejs node::Buffer is all that have base class ArrayBufferView.
node::Buffer::New's all make a Uint8Array. So most of our code stays the same

from hdf5.node.

rimmartin avatar rimmartin commented on July 22, 2024

node::Buffer::HasInstance now returns true on val->IsArrayBufferView(). Need to reorder and set a limit of support of older nodejs versions

from hdf5.node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.