Giter VIP home page Giter VIP logo

Comments (5)

giltene avatar giltene commented on June 9, 2024

Cool!

I'd be happy to chat directly, but we'll need some way to exchange e-mails for that (without putting them here where bots can find them). Message me @giltene via twitter if you want.

Comments:

  1. As you probably saw (#14), I recently deprecated HistogramData and folded it's functionality onto AbstractHistogram. For a .NET port, I'd get rid of it from the start.
  2. On licensing: Since HdrHistogram is public domain via CC0, you can do whatever you want with it (including no attribution, and any license you want). But thanks for the attribution! If you wish to license it the same way I did, and keep an attribution, I'd change the header to say e.g.:

/**

In addition, I've had people ask for an OSI license, so I added a BSD style license in addition. See https://github.com/HdrHistogram/HdrHistogram/blob/master/LICENSE.txt for that (you can just add a similar file at your base directory if you also want to do this.).

And if you want, I'll be happy to add you to the HdrHistogram org and have you include this .NET port under the same directory tree, similarly to what Mike Barker did with his C port.

from hdrhistogram.

mattwarren avatar mattwarren commented on June 9, 2024

Just sent a DM.

I'll try and get the C# port comparable with the Java one in the next few weeks. I've also got to check the perf, last time I looked C# was slower on all the perf tests (even testRawRecordingSpeed), so I need to work out why. Maybe it's just a case of Java Hotspot doing a better job when the code is jitted.

Once I've got the code in decent shape, I'll submit a pull-request that incorporates it into the main HdrHistorgram branch, thanks for the offer.

from hdrhistogram.

giltene avatar giltene commented on June 9, 2024

The Java v.2.0.1 is now up and ready for porting to C# ;-)

from hdrhistogram.

vitar avatar vitar commented on June 9, 2024

While this topic marked as work in progress, I'll post here.
In AbstractHistogram.cs incorrect exception message:
"numberOfSignificantValueDigits must be between 0 and 6"
should be
"numberOfSignificantValueDigits must be between 0 and 5"

Thanks for a project!

from hdrhistogram.

LeeCampbell avatar LeeCampbell commented on June 9, 2024

This work has been moved to https://github.com/HdrHistogram/HdrHistogram. I think this can be closed now.

from hdrhistogram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.