Comments (4)
+1
from hdrhistogram_c.
I didn't want to leak this function out to users outside of the hdr histogram, hence the lack of a prototype in the headers and instead including the prototype in the hdr_histogram_log.c. Is there a reason why the serialisation provided in hdr_histogram_log.{h,c} isn't sufficient? Are there some other use cases for this method that I'm missing?
I'm not dead-set against exposing this function, but would like to understand the use cases a bit more first.
from hdrhistogram_c.
It's been 3 months, but no follow-up to this issue therefore closing.
from hdrhistogram_c.
@mikeb01 sorry for the late reply:
- I reimplemented the serialization in the PHP library, because i wanted to convert the data to a structured PHP array that can then be serialized into anything, JSON, binary string or whatever else the user needs instead of forcing a base 64 encoded binary string, that cannot be processed further.
- I added an optimization in the export, where he detects when the last bucket with items in it is found and skips everything above it. This way you can make the stored data much smaller, because we only rarely have outliers in the buckets on the high end.
- I want to potentially decode the code in Go later, so a more structured serialization feels safe.
This also leads to having to implement a import, which requires the reset method to function.
The format for decode used in PHP is in C struct:
struct {
ltv long
htf long
sf long
counts long[]
}
from hdrhistogram_c.
Related Issues (20)
- Mirror the install header layout in the source tree HOT 8
- Suggest fuzzer for hdr_log_read()
- Version info needed in the repository HOT 4
- compile error: HDR_LOG_REQUIRED=ON and unable to find zlib library HOT 1
- hdr_value_at_percentile says 95th percentile of empty histogram is 63 HOT 1
- INTEGER_OVERFLOW in `src/hdr_histogram.c`
- FreeBSD 13.2 compilation error.
- undefined behavior (left shift of negative value) when encoding an empty histogram
- gcc 12.2 misoptimizes the code with `ipa-ra` when linking hdr_histogram_static into an `.so` file
- Please explain tagging strategy HOT 2
- hdr_histogram_log_test.decode_v3_log fails on Alpine Linux (musl libc) HOT 1
- Build issues HOT 3
- Build errors
- PackedHistogram support
- HDR count between 2 values HOT 4
- Documentation of the hdr_init HOT 2
- Road to 1.0. HOT 3
- hdr_value_at_percentile top on-cpu hotspots by function/LOC HOT 2
- If both the static library and the shared library install options are OFF, then configure fails
- ARM (Raspberry PI) build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hdrhistogram_c.