Giter VIP home page Giter VIP logo

Comments (3)

jonhoo avatar jonhoo commented on August 15, 2024

I think @marshallpierce has more insight into what else we might want to do before making these public. Might be fine to just mark them pub, but want to check with him first.

from hdrhistogram_rust.

marshallpierce avatar marshallpierce commented on August 15, 2024

Interesting. It's a bit of an abstraction-layer mangling to simply mark them pub, but I definitely want to support WASM use cases!

Anyone have thoughts on other ways to do this, perhaps by making a trait to represent derserialization strategies?

from hdrhistogram_rust.

EliSnow avatar EliSnow commented on August 15, 2024

There are two structs for serializing: V2Serializer and V2DeflateSerializer. Would it make sense to follow this pattern for deserializing? V2Deserializer and V2DeflateDeserializer? The only hickup I see is that the two serializers implement a common trait Serializer and if we wanted the deserializers to implement a common trait, it would have to be named something other than Deserializer since that's taken by the struct.

from hdrhistogram_rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.